Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix]fix modelscope compatible issue #6730

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

liuyhwangyh
Copy link
Contributor

@liuyhwangyh liuyhwangyh commented Jul 24, 2024

FIX download from www.modelscope.cn compatible issue.

FIX #6736

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@yingdachen
Copy link

LGTM as a quick compatbility fix

@DarkLight1337
Copy link
Member

DarkLight1337 commented Jul 24, 2024

Is this backwards-compatible? If not, we may have to pin the modelscope version accordingly.

@simon-mo simon-mo enabled auto-merge (squash) July 24, 2024 12:04
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 24, 2024
@simon-mo simon-mo merged commit f4f8a9d into vllm-project:main Jul 24, 2024
29 checks passed
@yingdachen
Copy link

Is this backwards-compatible? If not, we may have to pin the modelscope version accordingly.

yes. it is backward compatible.

the reason why this breaking change was introduced, is that the parameter serving the same purpose in huggingface bears a different name, but same name was assumed and used in the latest change.

cduk pushed a commit to cduk/vllm-pascal that referenced this pull request Aug 6, 2024
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
4 participants