-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix]fix modelscope compatible issue #6730
[Bugfix]fix modelscope compatible issue #6730
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
LGTM as a quick compatbility fix |
Is this backwards-compatible? If not, we may have to pin the modelscope version accordingly. |
yes. it is backward compatible. the reason why this breaking change was introduced, is that the parameter serving the same purpose in huggingface bears a different name, but same name was assumed and used in the latest change. |
Signed-off-by: Alvant <[email protected]>
FIX download from www.modelscope.cn compatible issue.
FIX #6736