[Bugfix] Fix speculative decode seeded test #6733
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into some issues that @njhill was facing with #6449 and realized that the test to verify per-request seeding for spec decode is not functioning correctly. This is because currently the
baseline_llm_generator
and thetest_llm_generator
are setting the same global seed.In order to ensure that the test cover the desired functionality, we need to allow for the baseline and test to get seeded differently, which is what is implemented in this PR.
I have verified that applying either of the following two changes would now cause the test to fail:
or