Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Add image placeholder for OpenAI Compatible Server of MiniCPM-V #6787

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

HwwwwwwwH
Copy link
Contributor

@HwwwwwwwH HwwwwwwwH commented Jul 25, 2024

Add image placeholder for OpenAI Compatible Server of MiniCPM-V

See #4087

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@HwwwwwwwH HwwwwwwwH changed the title [Bugfix] Add image placeholder for OpenAI Compatible Server [Bugfix] Add image placeholder for OpenAI Compatible Server of MiniCPM-V Jul 25, 2024
@HwwwwwwwH
Copy link
Contributor Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 25, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 25, 2024 16:30
@simon-mo simon-mo disabled auto-merge July 25, 2024 16:42
@simon-mo simon-mo merged commit b75e314 into vllm-project:main Jul 25, 2024
71 of 73 checks passed
cadedaniel pushed a commit to cadedaniel/vllm-public that referenced this pull request Jul 27, 2024
@HwwwwwwwH HwwwwwwwH deleted the minicpmv branch July 30, 2024 09:25
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants