Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Upgrade PyTorch nightly version #6845

Merged
merged 1 commit into from
Jul 27, 2024
Merged

[ROCm] Upgrade PyTorch nightly version #6845

merged 1 commit into from
Jul 27, 2024

Conversation

WoosukKwon
Copy link
Collaborator

Fixes #6807

Updates the ROCm PyTorch version from 0710 to 0726

@WoosukKwon WoosukKwon added rocm ready ONLY add when PR is ready to merge/full CI is needed labels Jul 26, 2024
@WoosukKwon WoosukKwon requested a review from hongxiayang July 26, 2024 19:31
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@hongxiayang hongxiayang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge as long as the CI signal is green

@WoosukKwon
Copy link
Collaborator Author

@hongxiayang Thanks for the confirmation! The PR passes all the AMD CI tests. :)

@WoosukKwon WoosukKwon enabled auto-merge (squash) July 27, 2024 03:15
@WoosukKwon WoosukKwon disabled auto-merge July 27, 2024 03:16
@WoosukKwon WoosukKwon merged commit ced36cd into main Jul 27, 2024
87 checks passed
@WoosukKwon WoosukKwon deleted the upgrade-rocm-torch branch July 27, 2024 03:16
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed rocm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][ROCm] The embedding layer does not support long inputs
2 participants