Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce eager mode with bnb quantization temporarily #6846

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

chenqianfzh
Copy link
Contributor

@chenqianfzh chenqianfzh commented Jul 26, 2024

Temporarily enforce eager_mode in bitsandbytes quantization before the known issue (#5569) is fixed.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

vllm/config.py Outdated Show resolved Hide resolved
Co-authored-by: Michael Goin <[email protected]>
@chenqianfzh
Copy link
Contributor Author

@mgoin Thanks for comments. Updated.

@chenqianfzh
Copy link
Contributor Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 26, 2024
@mgoin mgoin enabled auto-merge (squash) July 26, 2024 21:57
@mgoin mgoin merged commit bb54946 into vllm-project:main Jul 27, 2024
86 checks passed
cadedaniel pushed a commit to cadedaniel/vllm-public that referenced this pull request Jul 27, 2024
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
@devlup
Copy link

devlup commented Aug 29, 2024

bitsandbytes-foundation/bitsandbytes#1308 this issue got fixed , this will enable not to enforce eager mode ? @chenqianfzh @kylesayrs

@mgoin
Copy link
Member

mgoin commented Aug 29, 2024

@devlup correct but we need a new release of bitsandbytes to be made since we use the pypi package

@chenqianfzh chenqianfzh deleted the qian/enforce-eager-mode-in-bnb branch August 30, 2024 00:52
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants