Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] Fix input for flashinfer prefill wrapper. #7008

Merged
merged 9 commits into from
Aug 2, 2024
Merged

Conversation

LiuXiaoxuanPKU
Copy link
Collaborator

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@LiuXiaoxuanPKU
Copy link
Collaborator Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 31, 2024
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add a comment?
Also cc @SolitaryThinker

assert self.paged_kv_indices is not None
assert self.paged_kv_indptr is not None
assert self.paged_kv_last_page_len is not None
self.paged_kv_indices = self.paged_kv_indices.to(self.device)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per flashinfer-ai/flashinfer#362 (comment), perhaps we should keep this?

@ggbetz ggbetz mentioned this pull request Aug 1, 2024
6 tasks
@LiuXiaoxuanPKU LiuXiaoxuanPKU enabled auto-merge (squash) August 1, 2024 15:34
@WoosukKwon
Copy link
Collaborator

@LiuXiaoxuanPKU Just for a heads up: we just upgraded the PyTorch and FlashInfer versions in #6951

@WoosukKwon WoosukKwon disabled auto-merge August 2, 2024 01:44
@WoosukKwon WoosukKwon merged commit 954f730 into main Aug 2, 2024
62 of 64 checks passed
@WoosukKwon WoosukKwon deleted the flashinfer-fix branch August 2, 2024 01:44
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeError: Out of workspace memory in AlignedAlloactor when there is a lot of GPU memory left
4 participants