Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix DeepSeek remote code #7178

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Aug 6, 2024

Summary:

  • LM Eval Tests require the trust_remote_code flag to be enabled for DeepkSeek. PR adds an optional flag to the config file.

Copy link

github-actions bot commented Aug 6, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@dsikka
Copy link
Contributor Author

dsikka commented Aug 6, 2024

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 6, 2024
@dsikka dsikka changed the title fix deepseek remote code [Bug] Fix DeepSeek remote code Aug 6, 2024
@dsikka dsikka changed the title [Bug] Fix DeepSeek remote code [BugFix] Fix DeepSeek remote code Aug 6, 2024
@robertgshaw2-neuralmagic robertgshaw2-neuralmagic enabled auto-merge (squash) August 6, 2024 14:45
@simon-mo simon-mo disabled auto-merge August 6, 2024 15:16
@simon-mo simon-mo merged commit a3bbbfa into vllm-project:main Aug 6, 2024
51 of 53 checks passed
sfc-gh-mkeralapura pushed a commit to sfc-gh-mkeralapura/vllm that referenced this pull request Aug 12, 2024
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
fialhocoelho pushed a commit to opendatahub-io/vllm that referenced this pull request Aug 22, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants