Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Bandaid fix for speculative decoding tests #9327

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

tlrmchlsmth
Copy link
Collaborator

In #6484, the attention selection was changed to allow for attention-free models like Mamba to have a placeholder attention backend, as Mamba still needs attention metadata to manage its internal state.

The change was to call get_attn_backend even if num_attn_heads was zero. This is causing a divide-by-zero during self.model_config.get_head_size(). This PR skips get_attn_backend when num_attn_heads is zero, unless self.model_config.is_attention_free is set, which is OK is_attention_free is only True for Mamba at the moment.

This is a bandaid fix to get the build green, as this is a little hacky.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 13, 2024
@comaniac comaniac enabled auto-merge (squash) October 13, 2024 21:46
@comaniac comaniac merged commit 16b24e7 into vllm-project:main Oct 13, 2024
67 checks passed
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants