Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Stop silent failures on compressed-tensors parsing #9381

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Oct 15, 2024

Summary

  • compressed-tensors has been silently failing if there are any config parsing errors and just sets the input_activations to None in those cases, which results in downstream failures that hide the root problem
  • PR updates to stop the silent failure and changes the condition on input_quant

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 15, 2024
@mgoin
Copy link
Member

mgoin commented Oct 15, 2024

@dsikka
Copy link
Contributor Author

dsikka commented Oct 15, 2024

@dsikka I think there is a real issue in the CI here https://buildkite.com/vllm/ci-aws/builds/9886#0192911e-1065-4a85-8a1b-75071e80f1de/193-715

@mgoin Yup, which is why we need the PR which adds compressed-tensors to land. The current utils is out-of-date. This PR is secondary to make future failures more visible/not hide the root cause (i.e the issue you tagged is the real issue, which was silent before this PR)

@dsikka dsikka force-pushed the update-ct-actcase branch from 8e2c5d1 to a6b6121 Compare October 16, 2024 01:59
@dsikka dsikka requested a review from mgoin October 16, 2024 15:11
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@dsikka dsikka force-pushed the update-ct-actcase branch from 6e80f8a to bbacbbd Compare October 16, 2024 22:35
@mgoin mgoin enabled auto-merge (squash) October 18, 2024 01:38
@simon-mo simon-mo merged commit 48138a8 into vllm-project:main Oct 18, 2024
67 of 68 checks passed
charlifu pushed a commit to charlifu/vllm that referenced this pull request Oct 23, 2024
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Oct 23, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants