Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/Build] Test VLM embeddings #9406

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[CI/Build] Test VLM embeddings #9406

merged 1 commit into from
Oct 16, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 16, 2024
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 mentioned this pull request Oct 16, 2024
Merged
@DarkLight1337 DarkLight1337 changed the title [CI] Test VLM embeddings [CI/Build] Test VLM embeddings Oct 16, 2024
@Isotr0py Isotr0py enabled auto-merge (squash) October 16, 2024 06:46
@Isotr0py Isotr0py merged commit 1de76a0 into main Oct 16, 2024
90 checks passed
charlifu pushed a commit to charlifu/vllm that referenced this pull request Oct 23, 2024
@DarkLight1337 @charlifu
[CI/Build] Test VLM embeddings (vllm-project#9406)
d65bac3 
Signed-off-by: charlifu <[email protected]>
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Oct 23, 2024
@DarkLight1337 @vrdn-23
[CI/Build] Test VLM embeddings (vllm-project#9406)
ab3a871 
Signed-off-by: Vinay Damodaran <[email protected]>
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@DarkLight1337 @Alvant
[CI/Build] Test VLM embeddings (vllm-project#9406)
c4e2202 
Signed-off-by: Alvant <[email protected]>
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
@DarkLight1337 @garg-amit
[CI/Build] Test VLM embeddings (vllm-project#9406)
98a3367 
Signed-off-by: Amit Garg <[email protected]>
@simon-mo simon-mo deleted the vlm-embeddings-test branch October 28, 2024 16:51
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
@DarkLight1337 @FerdinandZhong
[CI/Build] Test VLM embeddings (vllm-project#9406)
f1123a6 
Signed-off-by: qishuai <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@DarkLight1337 @sumitd2
[CI/Build] Test VLM embeddings (vllm-project#9406)
291fd36 
Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@DarkLight1337
[CI/Build] Test VLM embeddings (vllm-project#9406)
495d2b9
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@DarkLight1337 @mfournioux
[CI/Build] Test VLM embeddings (vllm-project#9406)
c0c7054 
Signed-off-by: Maxime Fournioux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkLight1337 @Isotr0py