-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] Add min_pixels / max_pixels to Qwen2VL as mm_processor_kwargs #9612
[Model] Add min_pixels / max_pixels to Qwen2VL as mm_processor_kwargs #9612
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
a979740
to
da236a0
Compare
return _get_vision_info( | ||
image_processor, | ||
height=9999999, | ||
width=9999999, | ||
|
||
# Limit min / max pixels. | ||
min_pixels=max(image_processor.min_pixels, 28 * 28), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be enforced on actual requests also? I'm a bit confused why there are bounds on these values only while getting the max mm tokens, since it means actual requests can exceed the max like in one of the tests I added 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be enforced on actual requests also?
You mean requests coming in from online inference? Probably not, since this is model specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not generically, I mostly meant in the input processor and multimodal mappers for this class. It seemed a bit weird to only use an upper bound on max_pixels
in the max calculation, but not apply the same restriction in places like this, because it makes the max token per image count wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. @fyabc can you comment on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's still merge this PR first as this issue is already present in the existing code, so we can fix this in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM!
…vllm-project#9612) Signed-off-by: Alex-Brooks <[email protected]> Signed-off-by: charlifu <[email protected]>
…vllm-project#9612) Signed-off-by: Alex-Brooks <[email protected]> Signed-off-by: Alvant <[email protected]>
…vllm-project#9612) Signed-off-by: Alex-Brooks <[email protected]> Signed-off-by: Erkin Sagiroglu <[email protected]>
…vllm-project#9612) Signed-off-by: Alex-Brooks <[email protected]> Signed-off-by: qishuai <[email protected]>
…vllm-project#9612) Signed-off-by: Alex-Brooks <[email protected]> Signed-off-by: NickLucche <[email protected]>
…vllm-project#9612) Signed-off-by: Alex-Brooks <[email protected]> Signed-off-by: NickLucche <[email protected]>
…vllm-project#9612) Signed-off-by: Alex-Brooks <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
…vllm-project#9612) Signed-off-by: Alex-Brooks <[email protected]>
…vllm-project#9612) Signed-off-by: Alex-Brooks <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
…vllm-project#9612) Signed-off-by: Alex-Brooks <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
FIX #9545
This PR:
min_pixels
/max_pixels
asmm_processor_kwargs
for Qwen2VLmin_pixels
/max_pixels
Example usage for reference (
mm_processor_kwargs
can be passed at init time or inference time):sample output
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Adding or changing kernels
Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.
Tensors
require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.torch.libary.opcheck()
to test the function registration and meta-function for any registered ops. Seetests/kernels
for examples.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!