Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torch.compile] expanding support and fix allgather compilation #9637

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

CRZbulabula
Copy link
Contributor

This PR is to improve #9589, adding torch compile annotations to some models and testing them.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

CRZbulabula and others added 2 commits October 23, 2024 23:01
@youkaichao youkaichao changed the title [torch.compile] Adding torch compile annotations to some models [torch.compile] expanding support and fix allgather compilation Oct 24, 2024
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great work!

@youkaichao youkaichao added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 24, 2024
@youkaichao youkaichao enabled auto-merge (squash) October 24, 2024 06:17
@youkaichao youkaichao disabled auto-merge October 24, 2024 08:32
@youkaichao youkaichao merged commit ad6f780 into vllm-project:main Oct 24, 2024
48 of 50 checks passed
@CRZbulabula CRZbulabula deleted the torch-support branch October 24, 2024 09:11
MErkinSag pushed a commit to MErkinSag/vllm that referenced this pull request Oct 26, 2024
cooleel pushed a commit to cooleel/vllm that referenced this pull request Oct 28, 2024
cooleel pushed a commit to cooleel/vllm that referenced this pull request Oct 28, 2024
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
…-project#9637)

Signed-off-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants