-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Chat-based Embeddings API #9759
Merged
Merged
Changes from 43 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
1b91750
Initial implementation
DarkLight1337 61e0fcf
Update docs
DarkLight1337 c62be47
Cleanup
DarkLight1337 cc999b1
Consolidate and make code consistent
DarkLight1337 9ed87c1
Remove useless statement
DarkLight1337 efa7c6f
Rename back
DarkLight1337 ab9297e
Factor out common code
DarkLight1337 5a4f271
Reinstate truncate_prompt_tokens check
DarkLight1337 4a969b4
Rename
DarkLight1337 279b9ce
Fix
DarkLight1337 7de803f
Remove unused code
DarkLight1337 c1ef363
Migrate tokenization API
DarkLight1337 a10fa85
Some fixes
DarkLight1337 89e0710
format
DarkLight1337 81b94de
remoev unused imports
DarkLight1337 a79d3b2
Migrate chat and completion APIs
DarkLight1337 8b950dd
Factor out trace headers code
DarkLight1337 2c91855
Merge branch 'main' into chat-embeddings-api
DarkLight1337 f5e72ff
Clean
DarkLight1337 9cd1ac3
More precise error handling
DarkLight1337 d775150
Add and update tests
DarkLight1337 f2b5846
Cleanup
DarkLight1337 4a25806
Fix tests
DarkLight1337 bbcfc6a
Update docs
DarkLight1337 b6820b7
Add docs
DarkLight1337 fed887a
Fix doc failure
DarkLight1337 1774b27
Mock out starlette
DarkLight1337 c94aa93
Try fix docs
DarkLight1337 e2ecbcd
Cleanup docs
DarkLight1337 fbbd8b1
Fix newlines
DarkLight1337 50ad3aa
Reword
DarkLight1337 9c1df21
Fix
DarkLight1337 8049030
Update
DarkLight1337 a387845
Update
DarkLight1337 d80ec7e
Update
DarkLight1337 ea5fd96
format
DarkLight1337 b05ede6
Convert to tip
DarkLight1337 dba9806
newline
DarkLight1337 557c9ef
Fix missing client
DarkLight1337 8c8ee96
Merge branch 'main' into chat-embeddings-api
DarkLight1337 c3ba030
Merge branch 'main' into chat-embeddings-api
DarkLight1337 46f316f
Optionally initialize request handlers
DarkLight1337 1179f66
Update tip
DarkLight1337 eb4b235
Update tests
DarkLight1337 bf46a16
format
DarkLight1337 7f188f9
Rename
DarkLight1337 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
Pooling Parameters | ||
================== | ||
|
||
.. autoclass:: vllm.PoolingParams | ||
:members: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving this as a thought here: should we perhaps have a fork of the openai client that support our extensions explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds good, but not sure whether we have bandwidth to maintain it 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest opening an issue for this.