Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/build] Configure dependabot to update pip dependencies #9811

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Oct 29, 2024

Configure dependabot to update versions of the existing requirements-*.txt file and also generated requirements-*.txt file from running pip-compile on *.in file

p
Signed-off-by: kevin <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Oct 29, 2024
p
Signed-off-by: kevin <[email protected]>
@khluu khluu requested a review from simon-mo October 29, 2024 20:10
@khluu khluu marked this pull request as ready for review October 29, 2024 20:10
khluu added 2 commits October 29, 2024 20:17
p
Signed-off-by: kevin <[email protected]>
p
Signed-off-by: kevin <[email protected]>
@khluu
Copy link
Collaborator Author

khluu commented Oct 29, 2024

Looks like our GHA setting doesn't allow this yet: GitHub Actions is not permitted to create or approve pull requests. -

@simon-mo
Copy link
Collaborator

why not dependabot?

khluu added 2 commits October 29, 2024 22:29
p
Signed-off-by: kevin <[email protected]>
p
Signed-off-by: kevin <[email protected]>
@khluu khluu changed the title [ci/build] GHA workflow to periodically update CI dependencies [ci/build] Configure dependabot to update pip dependencies Oct 29, 2024
@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 30, 2024
Copy link
Collaborator

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR lgtm. I had some questions about some of the expected behavior, but I think it'll be easier just to see the PRs it generates and tweak from there.

@khluu khluu enabled auto-merge (squash) October 31, 2024 21:23
@khluu khluu merged commit b63c64d into main Oct 31, 2024
51 checks passed
@khluu khluu deleted the khluu/gha_workflow_update_ci_deps branch October 31, 2024 22:55
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
bigPYJ1151 pushed a commit to bigPYJ1151/vllm that referenced this pull request Nov 5, 2024
hissu-hyvarinen pushed a commit to ROCm/vllm that referenced this pull request Nov 6, 2024
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
sergeykochetkov pushed a commit to sergeykochetkov/vllm_spec_decoding that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants