-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/Build] Add Model Tests for PixtralHF #9813
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Ah okay @ywang96, sure it can wait |
"pixtral_hf": VLMTestInfo( | ||
models=["nm-testing/pixtral-12b-FP8-dynamic"], | ||
test_type=(VLMTestType.IMAGE, VLMTestType.MULTI_IMAGE), | ||
prompt_formatter=lambda img_prompt: f"<s>[INST]{img_prompt}[/INST]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prompt_formatter=lambda img_prompt: f"<s>[INST]{img_prompt}[/INST]", | |
prompt_formatter=lambda img_prompt: f"<s>[INST]\n{img_prompt}[/INST]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually based on the example script, there should be a newline here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DarkLight1337 From the HF example, the newline is actually supposed to be between the prompt and the images i.e.
PROMPT = "<s>[INST]Describe the images.\n[IMG][IMG][IMG][IMG][/INST]"
prompt = f"<s>[INST]{question}\n[IMG][/INST]" |
I wasn't sure how to do this with this structure, but it wasn't important to get matching vLLM vs HF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see now. You can use the img_idx_to_prompt
argument for using [IMG]
token instead of <image>
. We need to update the test framework to be able to support custom joining between text and image parts though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I did use img_idx_to_prompt=lambda idx: "[IMG]",
and that worked thankfully. Luckily the newline isn't crucial for correctness, so that feature can wait
Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Richard Liu <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
Adds a simple vLLM vs HF test for PixtralHF models
Tested locally with