Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin dependency versions in Dockerfile.tpu #9898

Closed
wants to merge 4 commits into from
Closed

Pin dependency versions in Dockerfile.tpu #9898

wants to merge 4 commits into from

Conversation

richardsliu
Copy link
Contributor

Pin the dependencies in Dockerfile.tpu to versions that work for Trillium

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Oct 31, 2024
@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 1, 2024
@richardsliu
Pin dockerfile
73813db 
Signed-off-by: Richard Liu <[email protected]>
@richardsliu
fix manual installation
cb6716f 
Signed-off-by: Richard Liu <[email protected]>
@bvrockwell
Copy link
Contributor

Hi @youkaichao it looks like we have a failing tpu test because of depyf not supporting torch nightly (breaking change with check_fn). Any tips on what to do?

@youkaichao
Copy link
Member

thanks for the heads-up! let me fix it really quickly.

@WoosukKwon WoosukKwon added the tpu Related to Google TPUs label Nov 3, 2024
youkaichao
youkaichao reviewed Nov 4, 2024
View reviewed changes
Dockerfile.tpu
RUN --mount=type=cache,target=/root/.cache/pip \
python3 -m pip install torch_xla[pallas] -f https://storage.googleapis.com/jax-releases/jax_nightly_releases.html -f https://storage.googleapis.com/jax-releases/jaxlib_nightly_releases.html
# Install PyTorch and PyTorch XLA.
RUN pip install --pre torch==2.6.0.dev20241028+cpu torchvision==0.20.0.dev20241028+cpu --index-url https://download.pytorch.org/whl/nightly/cpu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to install a cpu version first?

@youkaichao
Copy link
Member

@bvrockwell the depyf issue should be solved by thuml/depyf#64 . I think there's still an torch xla error from the ci results.

This was referenced Nov 4, 2024
Closed
Merged
@DarkLight1337
Copy link
Member

Closing as superseded by #10010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao left review comments

Assignees
No one assigned
Labels
ci/build documentation Improvements or additions to documentation tpu Related to Google TPUs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richardsliu @bvrockwell @youkaichao @DarkLight1337 @WoosukKwon