-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Create a vulnerability management team #9925
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
We could automate the discovery and reporting of such issues using Snyk's GitHub integration. https://docs.snyk.io/scm-ide-and-ci-cd-integrations/snyk-scm-integrations/github |
Indeed, though I'd prefer to keep that separate from clarifying the people and process for handling security issues. |
I'm in favor. Is there a way to document the members of the team? (similar to Thank you for proposing this. |
I left a spot in the proposed document to list the team members. That would provide the public view of the list. GitHub also supports having a team for "security managers" in your GitHub organization. This would be done at the github.com/vllm-project level. Details here: https://docs.github.com/en/organizations/managing-peoples-access-to-your-organization-with-roles/managing-security-managers-in-your-organization I think that's what you want -- a team that grants only the permissions necessary for viewing and editing security reports.
Sure! Thanks for taking a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I believe we can also mention corresponding channels in the vLLM Slack workspace.
The project has a policy for how vulnerabilties are reported, but there is no specific indivudual(s) who has the responsibility for ensuring that these reports are acted on in a timely manner. To address this, I propose naming a "vulnerability management team" who would have this responsibility. The list of individuals that would seed this team is TBD. Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
I pushed another commit to:
This is ready to go now, IMO. |
If there is support for this proposal, we should name an initial group for the
vulnerability management team. I'm happy to serve in the role if the project
maintainers are interested, but I am of course happy to put any names here that
you see fit.
4d5bbcc [Doc] Propose a vulnerability management team
commit 4d5bbcc
Author: Russell Bryant [email protected]
Date: Fri Nov 1 16:46:48 2024 +0000