Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Create a vulnerability management team #9925

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

russellb
Copy link
Collaborator

@russellb russellb commented Nov 1, 2024

If there is support for this proposal, we should name an initial group for the
vulnerability management team. I'm happy to serve in the role if the project
maintainers are interested, but I am of course happy to put any names here that
you see fit.

4d5bbcc [Doc] Propose a vulnerability management team

commit 4d5bbcc
Author: Russell Bryant [email protected]
Date: Fri Nov 1 16:46:48 2024 +0000

[Doc] Propose a vulnerability management team

The project has a policy for how vulnerabilties are reported, but
there is no specific indivudual(s) who has the responsibility for
ensuring that these reports are acted on in a timely manner. To
address this, I propose naming a "vulnerability management team" who
would have this responsibility.

The list of individuals that would seed this team is TBD.

Signed-off-by: Russell Bryant <[email protected]>

Copy link

github-actions bot commented Nov 1, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 1, 2024
@hmellor
Copy link
Collaborator

hmellor commented Nov 2, 2024

We could automate the discovery and reporting of such issues using Snyk's GitHub integration.

https://docs.snyk.io/scm-ide-and-ci-cd-integrations/snyk-scm-integrations/github

@russellb
Copy link
Collaborator Author

russellb commented Nov 4, 2024

We could automate the discovery and reporting of such issues using Snyk's GitHub integration.

https://docs.snyk.io/scm-ide-and-ci-cd-integrations/snyk-scm-integrations/github

Indeed, though I'd prefer to keep that separate from clarifying the people and process for handling security issues.

@russellb russellb marked this pull request as ready for review November 8, 2024 14:41
@russellb russellb requested a review from simon-mo November 8, 2024 14:41
@simon-mo
Copy link
Collaborator

I'm in favor. Is there a way to document the members of the team? (similar to CODEOWNERS)? And how do I give folks access to the current list of security advisories without giving admin rights?

Thank you for proposing this.

@russellb
Copy link
Collaborator Author

I'm in favor. Is there a way to document the members of the team? (similar to CODEOWNERS)? And how do I give folks access to the current list of security advisories without giving admin rights?

I left a spot in the proposed document to list the team members. That would provide the public view of the list.

GitHub also supports having a team for "security managers" in your GitHub organization. This would be done at the github.com/vllm-project level. Details here: https://docs.github.com/en/organizations/managing-peoples-access-to-your-organization-with-roles/managing-security-managers-in-your-organization

I think that's what you want -- a team that grants only the permissions necessary for viewing and editing security reports.

Thank you for proposing this.

Sure! Thanks for taking a look.

Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I believe we can also mention corresponding channels in the vLLM Slack workspace.

The project has a policy for how vulnerabilties are reported, but
there is no specific indivudual(s) who has the responsibility for
ensuring that these reports are acted on in a timely manner. To
address this, I propose naming a "vulnerability management team" who
would have this responsibility.

The list of individuals that would seed this team is TBD.

Signed-off-by: Russell Bryant <[email protected]>
@russellb
Copy link
Collaborator Author

LGTM. I believe we can also mention corresponding channels in the vLLM Slack workspace.

I pushed another commit to:

  • add you and I as the initial VMT members
  • point people to #security on Slack for security discussion (but not about private vulnerabilities)
  • add a link to the vulnerability management doc from SECURITY.md.

This is ready to go now, IMO.

@russellb russellb changed the title [RFC] Propose a vulnerability management team [Doc] Propose a vulnerability management team Dec 13, 2024
@russellb russellb changed the title [Doc] Propose a vulnerability management team [Doc] Create a vulnerability management team Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants