-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Improve benchmark documentation #9927
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes lgtm overall.
The one thing I'd change if you have to update this anyway is to try to get git to recognize benchmarks.rst
as a move instead of a delete + create. As it is, you lose history of the file. Generally git mv
will do what you want.
e18a232
to
abc5927
Compare
Signed-off-by: Rafael Vasquez <[email protected]>
4835e70
to
4806ab6
Compare
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]> Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
This PR tries to improve the documentation regarding vLLM performance including benchmarking vLLM where information can be found in multiple places (1, 2)
A possible follow-up to this PR would be to clean up the docs found in the repo assuming that's where the detailed, technical information will live, otherwise it should get pulled out for the website docs.