Merge pull request #15 from vmpowerio/fix-14

Call end() on readable stream buffer to enable piping
vmpowerio · Jan 10, 2017 · 0cdf7fa · 0cdf7fa
2 parents 4e50a1b + acfeb7a
commit 0cdf7fa
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -96,6 +96,7 @@ class ChartjsNode {
                 chunkSize: 2048     // in bytes.
             });
             readableStream.put(buffer);
+            readableStream.stop();
             return {
                 stream: readableStream,
                 length: buffer.length

diff --git a/test/index.js b/test/index.js
@@ -104,7 +104,22 @@ describe('chartjs', function () {
             })
             .then(imageStream => {
                 assert(imageStream.stream instanceof stream.Readable);
-                debug('Sucessfully wrote image to a Readable stream');
+                var length = imageStream.length;
+                var readLength = 0;
+                return new Promise((resolve, reject) => {
+                    imageStream.stream.on('data', d => {
+                        readLength += d.length;
+                        if (readLength === length) {
+                            debug('Sucessfully wrote image to a Readable stream');
+                            resolve();
+                        }
+                    });
+                    setTimeout(() => {
+                        debug('length: ' + length);
+                        debug('readLength: ' + readLength);
+                        reject('Failed to read complete chart image stream in time');
+                    }, 1000);
+                });
             });
         });
         it('should return the image as data url', function () {