This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
supports ruby 1.9+ #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, the ruby core team has retired ruby 1.8, so dropping support for pre-1.9 is probably the right thing to do! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old versions of ruby (pre 1.9) added the current directory to the $LOAD_PATH, however new versions of ruby (1.9+) do not. Starting with modern ruby versions 1.9 and greater (including OSX Mavericks, which uses ruby 2.0 for /usr/bin/ruby), the scripts will no longer work correctly, due to this issue.
This pull request fixes that problem, by using the require_relative method to load the helpers.rb file.
Ruby 1.9+ is now REQUIRED with this change. If we want to support versions prior to ruby 1.9, we can also add this. If so, how old a version would we like to support?