Merge pull request #1994 from mklanjsek/prefs-issue

Fixed problem with preferences forcing app reload
vmware-archive · Feb 11, 2021 · 7fded95 · 7fded95
2 parents 5e6cf6c + 50114ab
commit 7fded95
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/web/src/app/modules/shared/services/preferences/preferences.service.ts b/web/src/app/modules/shared/services/preferences/preferences.service.ts
@@ -130,7 +130,9 @@ export class PreferencesService implements OnDestroy {
     const isLightTheme = update['general.theme'] === 'light';
     const frontendUrl = update['development.frontendUrl'];
     const verbose = update['development.verbose'] === 'debug';
-    const embedded = update['development.embedded'] === 'embedded';
+    const embedded = update['development.embedded']
+      ? update['development.embedded'] === 'embedded'
+      : true;
     let notificationRequired = false;
 
     if (this.showLabels.value !== showLabels) {
@@ -145,7 +147,7 @@ export class PreferencesService implements OnDestroy {
       this.themeService.switchTheme();
     }
 
-    if (this.frontendUrl.value !== frontendUrl) {
+    if (frontendUrl && this.frontendUrl.value !== frontendUrl) {
       notificationRequired = true;
       this.frontendUrl.next(frontendUrl);
     }