This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Add examples to show different configs in which datagrid action menu can be displayed #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menu can be displayed **What was the change?** Examples to show different configs in which datagrid action menu can be displayed **Why was this change made?** The action display config input to datagrid is a nested object that is used to display action menu inside a datagrid in different ways. And there is no example that would help the library users to learn this quickly. # What testing was performed on this change? Opened the examples app on local server and tested that the example is rendered correctly Signed-off-by: ps37 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
=======================================
Coverage 86.38% 86.38%
=======================================
Files 106 106
Lines 3379 3379
Branches 533 533
=======================================
Hits 2919 2919
Misses 303 303
Partials 157 157 Continue to review full report at Codecov.
|
irahov
approved these changes
May 25, 2021
| @@ -0,0 +1,159 @@ | |||
| /*! | |||
| * Copyright 2019 VMware, Inc. | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What does this change do?
Examples to show different configs in which Datagrid action menu can be displayed. The action display config input to Datagrid is a nested object that is used to display the action menu inside a data grid in different ways. And there is no example that would help library users to learn this quickly.
What manual testing did you do?
Opened the examples app on local server and tested that the example is rendered correctly
Screenshots (if applicable)
Screen.Recording.2021-04-21.at.9.04.06.PM.mov
Does this PR introduce a breaking change?