This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
[i18n] Add number formatting to the translation service based on the user locale #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user locale Description =========== Currently the decimal point in the numbers was incorrect for some locales (IT, ES, FR, DE, pt-BR) - it was displayed as dot, but should be coma. Fix Description =============== Add a format number method that uses Intl.NumberFormat() method to format the number based on locale Note: I have added 2 default format options: * `maximumFractionDigits: 20` - The default one is 3. We need to override this to be able to respect user defined precision if it is set * `useGrouping: false` - Disable grouping, since currently we are not using any grouping of the large numbers (ex. number = 1234567.89, Output with grouping: 1,234,567.89, Output without grouping: 1234567.89). Testing Done =========== * All unit tests are passing * The changes are tested within VCD application Signed-off-by: Presiana Dimitrova <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What does this change do?
Add number formatting to the translation service based on the user locale
Description
Currently the decimal point in the numbers was incorrect for some locales (IT, ES, FR, DE, pt-BR) - it was displayed as dot, but should be coma.
Fix Description
Add a format number method that uses Intl.NumberFormat() method to format the number based on locale
Note: I have added 2 default format options:
maximumFractionDigits: 20- The default one is 3. We need to override this to be able to respect user defined precision if it is setuseGrouping: false- Disable grouping, since currently we are not using any grouping of the large numbers (ex. number = 1234567.89, Output with grouping: 1,234,567.89, Output without grouping: 1234567.89).What manual testing did you do?
Expected:
The number format displays correctly for FR/ES/DE/IT/pt-BR languages, the decimal point is displayed as comma.
Does this PR introduce a breaking change?
Other information