Skip to content

Commit

Permalink
fix(datagrid): update datagrid virtual scroll selector name (#1700)
Browse files Browse the repository at this point in the history
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
Current virtual scroll selector follow `Pascal Case` pattern.

Issue Number: N/A

## What is the new behavior?
Virtual scroll selector follow `Camel Case` pattern.
The original `Pascal Case` pattern is still supported, but deprecated.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

## Other information
  • Loading branch information
valentin-mladenov authored Feb 5, 2025
1 parent 91a7081 commit 6620a51
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ const DatagridDetailsTemplate: StoryFn = args => ({
<ng-template
*ngIf="data.elements"
ClrVirtualScroll
clrVirtualScroll
let-element
let-index="index"
[clrVirtualRowsOf]="data.elements"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ const DatagridTemplate: StoryFn = args => ({
<ng-template
*ngIf="data.elements"
ClrVirtualScroll
clrVirtualScroll
let-element
let-index="index"
[clrVirtualRowsOf]="data.elements"
Expand Down
2 changes: 1 addition & 1 deletion projects/angular/clarity.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -5855,7 +5855,7 @@ export class ÇlrDatagridVirtualScrollDirective<T> implements AfterViewInit, DoC
// (undocumented)
renderedRangeChange: EventEmitter<ListRange>;
// (undocumented)
static ɵdir: i0.ɵɵDirectiveDeclaration<ÇlrDatagridVirtualScrollDirective<any>, "[ClrVirtualScroll]", never, { "cdkVirtualForOf": "clrVirtualRowsOf"; "cdkVirtualForTrackBy": "clrVirtualRowsTrackBy"; "cdkVirtualForTemplate": "clrVirtualRowsTemplate"; "cdkVirtualForTemplateCacheSize": "clrVirtualRowsTemplateCacheSize"; "itemSize": "clrVirtualRowsItemSize"; "minBufferPx": "clrVirtualRowsMinBufferPx"; "maxBufferPx": "clrVirtualRowsMaxBufferPx"; }, { "renderedRangeChange": "renderedRangeChange"; }, never, never, false, never>;
static ɵdir: i0.ɵɵDirectiveDeclaration<ÇlrDatagridVirtualScrollDirective<any>, "[clrVirtualScroll],[ClrVirtualScroll]", never, { "cdkVirtualForOf": "clrVirtualRowsOf"; "cdkVirtualForTrackBy": "clrVirtualRowsTrackBy"; "cdkVirtualForTemplate": "clrVirtualRowsTemplate"; "cdkVirtualForTemplateCacheSize": "clrVirtualRowsTemplateCacheSize"; "itemSize": "clrVirtualRowsItemSize"; "minBufferPx": "clrVirtualRowsMinBufferPx"; "maxBufferPx": "clrVirtualRowsMaxBufferPx"; }, { "renderedRangeChange": "renderedRangeChange"; }, never, never, false, never>;
// (undocumented)
static ɵfac: i0.ɵɵFactoryDeclaration<ÇlrDatagridVirtualScrollDirective<any>, [null, null, { skipSelf: true; }, null, null, null, null, null, null, null, null, null, null]>;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export interface Cells {
<ng-template
*ngIf="data.rows"
ClrVirtualScroll
clrVirtualScroll
let-row
[clrVirtualRowsOf]="data.rows"
[clrVirtualRowsItemSize]="24"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const defaultCdkFixedSizeVirtualScrollInputs: CdkFixedSizeVirtualScrollInputs =
};

@Directive({
selector: '[ClrVirtualScroll]',
selector: '[clrVirtualScroll],[ClrVirtualScroll]',
providers: [Items],
})
export class ClrDatagridVirtualScrollDirective<T> implements AfterViewInit, DoCheck, OnDestroy {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ <h3>Dynamic cols and rows</h3>

<ng-template
*ngIf="data.rows"
ClrVirtualScroll
clrVirtualScroll
let-row
[clrVirtualRowsOf]="data.rows"
[clrVirtualRowsItemSize]="24"
Expand Down Expand Up @@ -95,7 +95,7 @@ <h3>Dynamic rows with sorting</h3>

<ng-template
*ngIf="data.users"
ClrVirtualScroll
clrVirtualScroll
let-user
[clrVirtualRowsOf]="data.users"
[clrVirtualRowsItemSize]="32"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ <h2>Virtual scroll server side</h2>

<ng-template
*ngIf="data.users"
ClrVirtualScroll
clrVirtualScroll
let-user
[clrVirtualRowsOf]="data.users"
[clrVirtualRowsItemSize]="24"
Expand Down

0 comments on commit 6620a51

Please sign in to comment.