Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use cds-icon style api #1504

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mivaylo
Copy link
Contributor

@mivaylo mivaylo commented Aug 5, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2195

What is the new behavior?

Making use of a more proper CSS property for cds-icon-s

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Aug 5, 2024

👋 @mivaylo,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This PR introduces visual changes: 2222e8b
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-2195-use-correct-css-prop
git fetch https://github.com/vmware-clarity/ng-clarity.git 2222e8b7068504aeb6e081046ddc0aafa88e79c6
git cherry-pick 2222e8b7068504aeb6e081046ddc0aafa88e79c6
git push

@kevinbuhmann kevinbuhmann changed the title chore(cds-icon): make use of style api chore: use cds-icon style api Aug 5, 2024
Comment on lines 32 to +34
cds-icon,
clr-icon {
fill: var(--clr-tree-node-caret-disabled-color);
--color: var(--clr-tree-node-caret-disabled-color);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work in places we allow users project a clr-icon. We can only use --color when we own the element and know it will be a cds-icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants