-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use cds-icon
style api
#1504
base: main
Are you sure you want to change the base?
Conversation
👋 @mivaylo,
Thank you, 🤖 Clarity Release Bot |
This PR introduces visual changes: 2222e8b
|
cds-icon
style api
cds-icon, | ||
clr-icon { | ||
fill: var(--clr-tree-node-caret-disabled-color); | ||
--color: var(--clr-tree-node-caret-disabled-color); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work in places we allow users project a clr-icon
. We can only use --color
when we own the element and know it will be a cds-icon
.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-2195
What is the new behavior?
Making use of a more proper CSS property for cds-icon-s
Does this PR introduce a breaking change?
Other information