Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datagrid): render datagrid in initially hidden and OnPush components #1688

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

dtsanevmw
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2562

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Jan 29, 2025

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/cde-2562 branch 4 times, most recently from 5652189 to b64ddcb Compare January 29, 2025 23:20
Copy link
Contributor

This PR introduces visual changes: 20f7aec
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/cde-2562
git fetch https://github.com/vmware-clarity/ng-clarity.git 20f7aec4b751e434bfca09ed6e60b2e66e646149
git cherry-pick 20f7aec4b751e434bfca09ed6e60b2e66e646149
git push

Copy link
Contributor

This PR introduces visual changes: 33997a8
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/cde-2562
git fetch https://github.com/vmware-clarity/ng-clarity.git 33997a857c1ee26cda15519249c2b6b952f02015
git cherry-pick 33997a857c1ee26cda15519249c2b6b952f02015
git push

@dtsanevmw dtsanevmw marked this pull request as ready for review January 30, 2025 09:31
@dtsanevmw dtsanevmw requested a review from a team January 30, 2025 09:31
@kevinbuhmann
Copy link
Member

I would reword the PR title to "fix(datagrid): render datagrid in tabs with OnPush change detection" or similar. Describe the behavioral bug fix, not the technical code change. That would be better for the changelog.

@dtsanevmw dtsanevmw changed the title fix(datagrid): use observer for visibility checking fix(datagrid): render datagrid in initially hidden and onPush components Jan 31, 2025
@kevinbuhmann kevinbuhmann changed the title fix(datagrid): render datagrid in initially hidden and onPush components fix(datagrid): render datagrid in initially hidden and OnPush components Jan 31, 2025
Copy link
Member

@kevinbuhmann kevinbuhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I didn't test it myself though. Just have the once small simplification comment and then this is good to merge.

@dtsanevmw dtsanevmw merged commit 95c177a into main Feb 4, 2025
12 checks passed
@dtsanevmw dtsanevmw deleted the dtsanevmw/cde-2562 branch February 4, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants