-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datagrid): render datagrid in initially hidden and OnPush
components
#1688
Conversation
👋 @dtsanevmw,
Thank you, 🤖 Clarity Release Bot |
5652189
to
b64ddcb
Compare
This PR introduces visual changes: 20f7aec
|
b64ddcb
to
f2f3efe
Compare
This PR introduces visual changes: 33997a8
|
projects/demo/src/app/datagrid/basic-with-on-push/basic-on-push-wrapper.ts
Outdated
Show resolved
Hide resolved
I would reword the PR title to "fix(datagrid): render datagrid in tabs with |
OnPush
components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. I didn't test it myself though. Just have the once small simplification comment and then this is good to merge.
a9ad8c9
to
1cf18e3
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: CDE-2562
What is the new behavior?
Does this PR introduce a breaking change?
Other information