Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): add stories for header for smaller screens #977

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Commits on Oct 3, 2023

  1. fix(alert): remove hostBinding and use renderer for alert-hidden class (

    #976)
    
    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [ ] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    Using HostBinding for `alert-hidden` class Angular throws expression
    changed error which creates problems for unit tests in user projects
    
    Issue Number: CDE-1249
    
    ## What is the new behavior?
    Using `renderer` to set `alert-hidden` class on the host element
    manually which doesn’t have issues with change detection.
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    valentin-mladenov authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    534dcc1 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. chore: add v16 to issue template (#974)

    - Add v16 to issue template.
    - And clean up some inconsistencies.
    jerone authored Oct 4, 2023
    Configuration menu
    Copy the full SHA
    aa69d8b View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. fix(modal): update title font-family variable (#981)

    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [ ] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    
    The current variable is using Metropolis, because the variable is
    computed at the root level and is not recomputing when the cds-theme
    level changes the header font family above unless redeclared.
    
    Issue Number: Related to CDE-1283
    
    ## What is the new behavior?
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    
    ---------
    
    Co-authored-by: GitHub <[email protected]>
    williamernest and web-flow authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    656ca9b View commit details
    Browse the repository at this point in the history
  2. fix(card): update card header to correct font-weight (#980)

    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [ ] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    
    Since the title-font-weight value is not redeclared in the shim, the
    root value is computed and used.
    
    Issue Number: CDE-1283
    
    ## What is the new behavior?
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    williamernest authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    514432c View commit details
    Browse the repository at this point in the history
  3. fix(header): add correct header title font-weight value (#979)

    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [ ] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    
    Since the title-font-weight variable isn't redeclared, it's not
    recomputed and the original value from the root scope is used.
    
    <!-- Please describe the current behavior that you are modifying, or
    link to a relevant issue. -->
    
    Issue Number: Related to CDE-1283
    
    ## What is the new behavior?
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    
    ---------
    
    Co-authored-by: GitHub <[email protected]>
    williamernest and web-flow authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    984d6ec View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. chore(storybook): refactor signpost stories to csf (#943)

    Refactors the signpost to a standard CSFv3 story.
    
    ---------
    
    Co-authored-by: GitHub <[email protected]>
    williamernest and web-flow authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7e5f164 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. fix(accordion): update event type and add descriptions (#1005)

    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [x] Docs have been added / updated (for bug fixes / features)
    - [ ] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [x] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    
    The EventEmitter type was missing. This isn't a big issue for developers
    as the type is easily inferred, but the Storybook Docs tab doesn't infer
    the correct type.
    
    Issue Number: N/A
    
    ## What is the new behavior?
    
    The correct type is specified, and descriptions are added to
    inputs/outputs to be parsed by Storybook.
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    williamernest authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    e7efe73 View commit details
    Browse the repository at this point in the history
  2. chore(accordion): update storybook stories to csfv3 (#996)

    Updates the accordion stories to follow CSFv3. Adds individual stories
    for multiple configurations. Adds inline comments/type in component to
    ensure a description and appropriate type is used in storybook docs
    mode.
    
    ---------
    
    Co-authored-by: GitHub <[email protected]>
    williamernest and web-flow authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    9f26b10 View commit details
    Browse the repository at this point in the history
  3. fix(vertical-nav): align nav parent/child left padding (#1000)

    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [x] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    
    Vertical nav parent/child items are not left aligned.
    
    ![image](https://github.com/vmware-clarity/ng-clarity/assets/34519388/e8c5bb9e-a303-4d27-b127-c6afae9de9ae)
    
    
    Issue Number: CDE-1284
    
    ## What is the new behavior?
    
    Vertical nav parent/child items are left aligned. 
    
    ![image](https://github.com/vmware-clarity/ng-clarity/assets/34519388/f300e960-9933-45ab-83b3-5e4ef27243e5)
    
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [ ] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    
    ---------
    
    Co-authored-by: GitHub <[email protected]>
    williamernest and web-flow authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    a8024dc View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. chore(storybook): add tabs collapsed story to test smaller screens (#969

    )
    
    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [x] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [ ] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [ ] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    
    <!-- Please describe the current behavior that you are modifying, or
    link to a relevant issue. -->
    
    Issue Number: N/A
    
    ## What is the new behavior?
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    
    ---------
    
    Co-authored-by: GitHub <[email protected]>
    mivaylo and web-flow authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    479f7b3 View commit details
    Browse the repository at this point in the history
  2. fix(datagrid): align checkbox with text in datagrid (#1006)

    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [ ] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    
    Position of checkbox in data grid is not aligned with text.
    
    ![image](https://github.com/vmware-clarity/ng-clarity/assets/6692908/b876edd4-fed8-4804-ba8a-613296ed74af)
    
    
    Issue Number: CDE-1350
    
    ## What is the new behavior?
    
    Position of checkbox is centered with text's first line.
    
    ![image](https://github.com/vmware-clarity/ng-clarity/assets/6692908/e8e632ef-d186-4eb6-948d-8ab3c617fd11)
    
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    
    ---------
    
    Co-authored-by: GitHub <[email protected]>
    valentin-mladenov and web-flow authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    04a12dd View commit details
    Browse the repository at this point in the history
  3. fix(datagrid): update manage columns dialog close button color (#1008)

    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [X] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    
    The close icon on the manage columns dialog has an insufficient color
    contrast ratio.
    
    ![image](https://github.com/vmware-clarity/ng-clarity/assets/34519388/db04f37c-04a5-4bde-a833-413e4f736d11)
    
    Issue Number: CDE-1099
    
    ## What is the new behavior?
    
    The color has been updated to align with the spec. 
    <img width="262" alt="image"
    src="https://github.com/vmware-clarity/ng-clarity/assets/34519388/e6eaa8fc-e745-4389-ae55-8507cfc09986">
    
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    williamernest authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    0e62fd6 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. chore(vertical-nav): update routing story to include all top level it…

    …ems (#1019)
    
    Updates the routing vertical-nav story to include all top-level item
    types (links without a group, links with a group, buttons with a group).
    
    ---------
    
    Co-authored-by: GitHub <[email protected]>
    williamernest and web-flow authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    33d25ed View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. fix(label): remove has pseudo class selector (port of #1020) (#1024)

    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [ ] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [x] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [x] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    
    <!-- Please describe the current behavior that you are modifying, or
    link to a relevant issue. -->
    
    Issue Number: CDE-1356
    
    ## What is the new behavior?
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    valentin-mladenov authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    5ce535b View commit details
    Browse the repository at this point in the history
  2. chore(storybook): temp

    mivaylo committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    10f32c1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d973e47 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b6b0caf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dce434e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    96d30de View commit details
    Browse the repository at this point in the history
  7. Revert "chore(storybook): test viewport for visual snapshots"

    This reverts commit 96d30de.
    mivaylo committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    ea70870 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    63da4eb View commit details
    Browse the repository at this point in the history
  9. fix(tree-view): remove has css selector (port of #1020) (#1023)

    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [ ] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [x] Bugfix
    - [ ] Feature
    - [x] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    
    <!-- Please describe the current behavior that you are modifying, or
    link to a relevant issue. -->
    
    Issue Number: CDE-1355
    
    ## What is the new behavior?
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    valentin-mladenov authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    ec575aa View commit details
    Browse the repository at this point in the history
  10. fix(signpost): allow keyboard scrolling in overflow content (#1027)

    ## PR Checklist
    
    Please check if your PR fulfills the following requirements:
    
    - [ ] Tests for the changes have been added (for bug fixes / features)
    - [ ] Docs have been added / updated (for bug fixes / features)
    - [ ] If applicable, have a visual design approval
    
    ## PR Type
    
    What kind of change does this PR introduce?
    
    <!-- Please check the one that applies to this PR using "x". -->
    
    - [X] Bugfix
    - [ ] Feature
    - [ ] Code style update (formatting, local variables)
    - [ ] Refactoring (no functional changes, no api changes)
    - [ ] Build related changes
    - [ ] CI related changes
    - [ ] Documentation content changes
    - [ ] Other... Please describe:
    
    ## What is the current behavior?
    
    When you open a signpost with a scroll you can't use keyboard due to
    missing focus on the content.
    
    <!-- Please describe the current behavior that you are modifying, or
    link to a relevant issue. -->
    
    Issue Number: CDE-1397
    
    ## What is the new behavior?
    
    Now you can focus the content and scroll freely with the keyboard.
    
    ## Does this PR introduce a breaking change?
    
    - [ ] Yes
    - [X] No
    
    <!-- If this PR contains a breaking change, please describe the impact
    and migration path for existing applications below. -->
    
    ## Other information
    dtsanevmw authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    0164f85 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a2c8dbd View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3c99243 View commit details
    Browse the repository at this point in the history