Merge branch 'release-0.5.0'

.github/ISSUE_TEMPLATE/bug-report.md

@@ -0,0 +1,31 @@
+---
+name: Bug Report
+about: Create a bug report to help us improve VEBA
+title: ''
+labels: bug
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Version (please complete the following information):**
+ - VEBA Form Factor: [e.g. Appliance or K8s]
+ - VEBA Version: [e.g. v0.4.0]
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature-enhancement.md

@@ -0,0 +1,20 @@
+---
+name: Feature Enhancement
+about: Suggest a new idea or enhancement for VEBA
+title: ''
+labels: enhancement
+assignees: lamw
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,49 @@
+## Summary
+
+Please describe your changes and what you plan to introduce as part of this pull request submission. If it fixes a bug or resolves a feature request, be sure to link to the issue numbers following the template below.
+
+## Pull Request Checklist
+🚨 Please review the [guidelines for contributing](https://vmweventbroker.io/community) to this repository.
+
+- [ ] Please ensure that you are making a pull request against the **Development** branch
+- [ ] Please use the `WIP` keyword in the title of your PR if you are not ready for review
+- [ ] Please ensure that you have opened a Github Issue if you are resolving/fixing a problem
+- [ ] Please ensure that you have [signed](https://help.github.com/en/github/authenticating-to-github/signing-commits) all commits and that you have [squashed](https://medium.com/@slamflipstrom/a-beginners-guide-to-squashing-commits-with-git-rebase-8185cf6e62ec) all relevant commmits related to your change
+- [ ] Please make sure that you have tested your change locally by successfully [building and deploying the VMware Event Broker Appliance](https://vmweventbroker.io/kb/contribute-appliance) and/or [building and deploying VMware Event Router](https://vmweventbroker.io/kb/contribute-eventrouter)
+- [ ] Please include any relevant screenshots and/or output as part of your testing
+- [ ] Please include any documentation updates that is applicable for your changes
+
+## Change Type
+
+What types of changes does your code introduce to the VMware Event Broker Appliance?
+
+_Put an `x` in all boxes that apply_
+
+Please check the type of change your PR introduces:
+- [ ] Bugfix (non-breaking change which fixes an issue)
+- [ ] Feature (non-breaking change which adds functionality)
+- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
+- [ ] Code style update (formatting, renaming)
+- [ ] Refactoring (no functional changes, no api changes)
+- [ ] Build related changes
+- [ ] Documentation changes
+- [ ] Other (please describe):
+
+## Resolved Issues
+
+List of Issues closed or resolved by this PR. Add multiple `Closes` keyword followed by the issue number (e.g. Closes #ISSUE-NUMBER)
+
+* Closes #ISSUE-NUMBER
+
+## Testing Verification
+
+* Short summary of testing (e.g. successfully built and deployed VMware Event Broker Appliance)
+* Please include any relevant screenshots and/or output as part of the testing
+
+## Additional Information
+
+* Any other details you wish to include or mention
+
+If you have any questions/comments, feel free to reach out to team on Slack [#vcenter-event-broker-appliance](https://vmwarecode.slack.com/archives/CQLT9B5AA)
+
+Thank you from the VEBA Team! 🥳

.github/workflows/create-docker-dev-image.yml

@@ -0,0 +1,55 @@
+name: VMware Event Router Development Build
+
+# triggered on every push to development but only when changes inside
+# vmware-event-router (sub)dir(s)
+on:
+  push:
+    paths:
+      - "vmware-event-router/**"
+    branches:
+      - "development"
+
+# run all jobs with these defaults, unless specified otherwise
+defaults:
+  run:
+    shell: bash
+    working-directory: ./vmware-event-router
+
+jobs:
+  modules:
+    runs-on: ubuntu-latest
+    steps:
+      - name: checkout source
+        uses: actions/checkout@v2
+      - name: verify modules are up2date/unchanged
+        run: |
+          make tidy
+          [[ -z $(git status -s) ]] || (echo 'git dirty: modified and/or untracked'; git status -s; false)
+  build-push:
+    runs-on: ubuntu-latest
+    needs: modules
+    steps:
+      - name: checkout source (this.development branch)
+        uses: actions/checkout@v2
+      - name: get the short commit ID
+        id: get_short_commit
+        run: echo ::set-output name=COMMIT::$(echo $GITHUB_SHA | cut -c -8)
+      - name: log in to Docker
+        env:
+          DOCKER_USER: ${{ secrets.DOCKER_USER }}
+          DOCKER_SECRET: ${{ secrets.DOCKER_SECRET }}
+        run: echo "${DOCKER_SECRET}" | docker login -u "${DOCKER_USER}" --password-stdin
+      - name: test and build development image
+        env:
+          COMMIT: ${{ steps.get_short_commit.outputs.COMMIT }}
+        run: |
+          echo "Building development image for vmware-event-router with commit $COMMIT"        
+          make
+          docker tag vmware/veba-event-router:latest vmware/veba-event-router:$COMMIT
+          docker tag vmware/veba-event-router:latest vmware/veba-event-router:development
+      - name: push the development image
+        env:
+          COMMIT: ${{ steps.get_short_commit.outputs.COMMIT }}
+        run: |
+          docker push vmware/veba-event-router:$COMMIT
+          docker push vmware/veba-event-router:development

.github/workflows/create-docker-prerelease.yml

@@ -1,4 +1,4 @@
-name: Build and push VMware Event Router Pre-Release Image to Docker Hub
+name: Pre-Release VMware Event Router
 
 on:
   push:
@@ -11,11 +11,21 @@ defaults:
     working-directory: ./vmware-event-router
 
 jobs:
+  modules:
+    runs-on: ubuntu-latest
+    steps:
+      - name: checkout source
+        uses: actions/checkout@v2
+      - name: verify modules are up2date/unchanged
+        run: |
+          make tidy
+          [[ -z $(git status -s) ]] || (echo 'git dirty: modified and/or untracked'; git status -s; false)
   build-push:
     runs-on: ubuntu-latest
+    needs: modules
     steps:
       - name: checkout source (this.release branch)
-        uses: actions/checkout@master
+        uses: actions/checkout@v2
       - name: get the version from ref without prefixes
         id: get_version
         run: echo ::set-output name=VERSION::$(echo $GITHUB_REF | cut -d / -f 3)

.github/workflows/create-docker-release.yml

@@ -1,16 +1,31 @@
-name: Build and push VMware Event Router to Docker Hub
+name: Release VMware Event Router
 
 on:
   release:
     types:
       - published
 
+defaults:
+  run:
+    shell: bash
+    working-directory: ./vmware-event-router
+
 jobs:
+  modules:
+    runs-on: ubuntu-latest
+    steps:
+      - name: checkout source
+        uses: actions/checkout@v2
+      - name: verify modules are up2date/unchanged
+        run: |
+          make tidy
+          [[ -z $(git status -s) ]] || (echo 'git dirty: modified and/or untracked'; git status -s; false)
   build-push:
     runs-on: ubuntu-latest
+    needs: modules
     steps:
       - name: checkout source (master branch)
-        uses: actions/checkout@master
+        uses: actions/checkout@v2
         with:
           ref: 'master'
       - name: log in to Docker
@@ -19,4 +34,4 @@ jobs:
           DOCKER_SECRET: ${{ secrets.DOCKER_SECRET }}
         run: echo "${DOCKER_SECRET}" | docker login -u "${DOCKER_USER}" --password-stdin
       - name: test, build, tag and push image
-        run: cd vmware-event-router && make release
+        run: make release

.github/workflows/router-integration-tests.yml

@@ -0,0 +1,28 @@
+name: VMware Event Router Integration Tests
+
+# triggered on every push and PRs but only when changes inside
+# vmware-event-router (sub)dir(s)
+on:
+  pull_request:
+    types: [opened, synchronize, reopened]
+    paths:
+      - 'vmware-event-router/**'
+  push:
+    paths:
+      - 'vmware-event-router/**'
+
+# run all jobs with these defaults, unless specified otherwise
+defaults:
+  run:
+    shell: bash
+    working-directory: ./vmware-event-router
+
+jobs:
+  integration-tests:
+    runs-on: ubuntu-latest
+    steps:
+      - name: checkout source
+        uses: actions/checkout@v2
+      - name: run integration tests with OpenFaaS
+        run: hack/run_integration_tests.sh
+

.github/workflows/router-lint.yml

@@ -0,0 +1,34 @@
+name: VMware Event Router Linting
+
+# triggered on every push and PRs but only when changes inside
+# vmware-event-router (sub)dir(s)
+on:
+  pull_request:
+    types: [opened, synchronize, reopened]
+    paths:
+      - "vmware-event-router/**"
+  push:
+    paths:
+      - "vmware-event-router/**"
+jobs:
+  golangci:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        env:
+          GL_DEBUG: "loader,gocritic"
+        with:
+          # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
+          version: latest
+
+          # Optional: working directory, useful for monorepos
+          working-directory: vmware-event-router
+
+          # Optional: golangci-lint command line arguments.
+          args: --build-tags unit,integration -v
+
+          # Optional: show only new issues if it's a pull request. The default value is `false`.
+          # only-new-issues: true

.github/workflows/router-unit-tests.yml

@@ -1,8 +1,13 @@
 name: VMware Event Router Unit Tests
 
-# triggered on PRs but only when changes inside vmware-event-router (sub)dir(s)
+# triggered on every push and PRs but only when changes inside
+# vmware-event-router (sub)dir(s)
 on:
   pull_request:
+    types: [opened, synchronize, reopened]
+    paths:
+      - 'vmware-event-router/**'
+  push:
     paths:
       - 'vmware-event-router/**'
 
@@ -17,7 +22,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: checkout source
-        uses: actions/checkout@master
+        uses: actions/checkout@v2
       - name: run unit tests
-        run: make test
-
+        run: make unit-test

.github/workflows/router-verify-build.yml

@@ -0,0 +1,34 @@
+name: VMware Event Router Build Verification
+
+# triggered on every PRs to verify Docker builds but only when changes inside
+# vmware-event-router (sub)dir(s)
+on:
+  pull_request:
+    types: [opened, synchronize, reopened]
+    paths:
+      - 'vmware-event-router/**'
+
+# run all jobs with these defaults, unless specified otherwise
+defaults:
+  run:
+    shell: bash
+    working-directory: ./vmware-event-router
+
+jobs:
+  modules:
+    runs-on: ubuntu-latest
+    steps:
+      - name: checkout source
+        uses: actions/checkout@v2
+      - name: verify modules are up2date/unchanged
+        run: |
+          make tidy
+          [[ -z $(git status -s) ]] || (echo 'git dirty: modified and/or untracked'; git status -s; false)
+  docker-build:
+    runs-on: ubuntu-latest
+    needs: modules
+    steps:
+      - name: checkout source
+        uses: actions/checkout@v2
+      - name: verify Docker build (no push)
+        run: docker build -t vmware-event-router:build-test .

.github/workflows/stale-issues.yml

@@ -0,0 +1,20 @@
+name: "Close stale issues"
+on:
+  schedule:
+  # runs daily
+  - cron: '0 0 * * *'
+
+jobs:
+  stale:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/stale@v3
+      with:
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
+        days-before-stale: 30
+        days-before-close: 5
+        stale-issue-message: 'This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.'
+        close-issue-message: 'Closing issue due to inactivity.'
+        stale-issue-label: 'stale'
+        exempt-issue-labels: 'awaiting-approval,work-in-progress,wip'
+        remove-stale-when-updated: true

.gitignore

@@ -2,12 +2,18 @@ packer_cache/
 output-vmware-iso/
 dist/
 .vscode
+.idea
 username
 password
 secret*.json
+secret*.yml
 .jekyll-metadata
 .sass-cache
 .jekyll-cache
 _site
 Gemfile.lock
-.tweet-cache
+.tweet-cache
+*.coverprofile
+faas-cli*
+template
+checkpoints/