Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fluentbit config in order to process all logs #802

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

rguske
Copy link
Contributor

@rguske rguske commented Feb 17, 2022

Closes: #721
Signed-off-by: Robert Guske [email protected]

Summary

Since we now changed the container runtime from Docker to Containerd (#678), the Fluentbit configuration has to be updated in order to fix issue #721 and to finally process all logs now.

Pull Request Checklist

🚨 Please review the guidelines for contributing to this repository.

  • Please ensure that you are making a pull request against the Development branch
  • Please use the WIP keyword in the title of your PR if you are not ready for review
  • Please ensure that you have opened a Github Issue if you are resolving/fixing a problem
  • Please ensure that you have signed all commits and that you have squashed all relevant commits related to your change
  • Please make sure that you have tested your change locally by successfully building and deploying the VMware Event Broker Appliance and/or building and deploying VMware Event Router
  • Please include any relevant screenshots and/or output as part of your testing
  • Please include any documentation updates that is applicable for your changes

Change Type

What types of changes does your code introduce to the VMware Event Broker Appliance?

Put an x in all boxes that apply

Please check the type of change your PR introduces:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

Resolved Issues

Closes: #721

Testing Verification

  • All configuration changes were tested against a latest development build

Log output from an invoked kn-pcli-tag function:

screenshot_change_name 3

Log output from an invoked kn-pcli-nsx-tag-sync function:

screenshot_change_name

@rguske rguske requested a review from lamw February 17, 2022 11:42
@lamw lamw requested review from embano1 and removed request for lamw February 17, 2022 11:44
Copy link
Collaborator

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@embano1 embano1 merged commit 734d2f6 into vmware-samples:development Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fluent Bit does not process all logs in VEBA v0.7.0 because of Docker runtime
2 participants