fix(velero): remove useless nodeAgent.privileged

this clashes with the field `nodeAgent.containerSecurityContext.privileged` Signed-off-by: Chris Werner Rau <[email protected]>
vmware-tanzu · Jan 11, 2024 · 377a4ab · 377a4ab
1 parent ab0db25
commit 377a4ab
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/charts/velero/README.md b/charts/velero/README.md
@@ -90,6 +90,10 @@ helm upgrade vmware-tanzu/velero <RELEASE NAME> --reuse-values --set configurati
 
 ## Upgrading
 
+### Upgrading to 5.1.1
+
+This version removes the `nodeAgent.privileged` field, you should use `nodeAgent.containerSecurityContext.privileged` instead
+
 ### Upgrading to v1.12
 
 The [instructions found here](https://velero.io/docs/v1.12/upgrade-to-1.12/) will assist you in upgrading from version v1.11.x to v1.12.

diff --git a/charts/velero/templates/node-agent-daemonset.yaml b/charts/velero/templates/node-agent-daemonset.yaml
@@ -175,7 +175,6 @@ spec:
           lifecycle: {{ toYaml .Values.nodeAgent.lifecycle | nindent 12 }}
           {{- end }}
           securityContext:
-            privileged: {{ .Values.nodeAgent.privileged }}
             {{- with $containerSecurityContext }}
               {{- toYaml . | nindent 12 }}
             {{- end }}

diff --git a/charts/velero/values.yaml b/charts/velero/values.yaml
@@ -516,7 +516,6 @@ deployNodeAgent: false
 
 nodeAgent:
   podVolumePath: /var/lib/kubelet/pods
-  privileged: false
   # Pod priority class name to use for the node-agent daemonset. Optional.
   priorityClassName: ""
   # Resource requests/limits to specify for the node-agent daemonset deployment. Optional.