Skip to content

Commit

Permalink
fix(velero): remove useless nodeAgent.privileged
Browse files Browse the repository at this point in the history
this clashes with the field `nodeAgent.containerSecurityContext.privileged`

Signed-off-by: Chris Werner Rau <[email protected]>
  • Loading branch information
cwrau committed Oct 16, 2023
1 parent 1e6a5b4 commit 6ef3d69
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion charts/velero/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: 1.12.0
kubeVersion: ">=1.16.0-0"
description: A Helm chart for velero
name: velero
version: 5.1.0
version: 5.1.1
home: https://github.com/vmware-tanzu/velero
icon: https://cdn-images-1.medium.com/max/1600/1*-9mb3AKnKdcL_QD3CMnthQ.png
sources:
Expand Down
4 changes: 4 additions & 0 deletions charts/velero/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ helm upgrade vmware-tanzu/velero <RELEASE NAME> --reuse-values --set configurati

## Upgrading

### Upgrading to 5.1.1

This version removes the `nodeAgent.privleged` field, you should use `nodeAgent.containerSecurityContext.privileged` instead

### Upgrading to v1.12

The [instructions found here](https://velero.io/docs/v1.12/upgrade-to-1.12/) will assist you in upgrading from version v1.11.x to v1.12.
Expand Down
1 change: 0 additions & 1 deletion charts/velero/templates/node-agent-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,6 @@ spec:
lifecycle: {{ toYaml .Values.nodeAgent.lifecycle | nindent 12 }}
{{- end }}
securityContext:
privileged: {{ .Values.nodeAgent.privileged }}
{{- with $containerSecurityContext }}
{{- toYaml . | nindent 12 }}
{{- end }}
Expand Down
1 change: 0 additions & 1 deletion charts/velero/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,6 @@ deployNodeAgent: false

nodeAgent:
podVolumePath: /var/lib/kubelet/pods
privileged: false
# Pod priority class name to use for the node-agent daemonset. Optional.
priorityClassName: ""
# Resource requests/limits to specify for the node-agent daemonset deployment. Optional.
Expand Down

0 comments on commit 6ef3d69

Please sign in to comment.