-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change to upgrade job values #547
base: main
Are you sure you want to change the base?
Conversation
Why do we require to increase the memory limits? |
Please refer to below PR by my team member who did it for azure backup. In some customer we observed that upgradejob were getting OOMKilled after the maintenance window, they only got mitigated after they increased the limits to 512 earlier PR- #514 |
Signed-off-by: soumyapattnaik <[email protected]>
Signed-off-by: soumyapattnaik <[email protected]>
Signed-off-by: soumyapattnaik <[email protected]>
Signed-off-by: soumyapattnaik <[email protected]>
Signed-off-by: soumyapattnaik <[email protected]>
@jenting can we uncomment https://github.com/vmware-tanzu/helm-charts/pull/524/files and bump up memory based on this PR. |
might need to uncomment default values
@jenting lint-test failed with checking the chart version, should we bump up the version? or could someone approve it directly? As I've committed to this PR, I cannot approve it now. |
@qiuming-best yez, the Chart version should upgrade as well. |
@qiuming-best what are your thoughts on uncommenting the values? |
For version bump I'll ask @soumyapattnaik |
Please don't uncomment, user could overwrite the value by their own. The comment value is the suggestion, not the mandatory value. |
Alright sure |
updated chart.yaml to 6.0.1 |
Could you please help bump the version? |
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[velero]
)