Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[velero] Allow passing custom arguments to velero server CLI #572

Merged
merged 1 commit into from
May 15, 2024
Merged

[velero] Allow passing custom arguments to velero server CLI #572

merged 1 commit into from
May 15, 2024

Conversation

jacksgt
Copy link
Contributor

@jacksgt jacksgt commented May 13, 2024

Hi all,

thanks for maintaining this Helm chart. It's a great help in deploying velero.

I came across a use case where I need to add a new flag for the velero server CLI (--disable-informer-cache in 1.13).
Over time new arguments get added to the velero CLI and I think in general it is helpful to have a generic way of setting these arguments because (for a cluster administrator) it decouples Helm charts upgrades from application (velero) upgrades.

Many other Helm charts implement this pattern as well, e.g. https://github.com/bitnami/charts/blob/9acd313bffb76611d3364b94ed0a7d7e611990d9/bitnami/mariadb/values.yaml#L1115

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped, please refer to the chart version instruction
  • Variables are documented in the values.yaml or README.md
  • Title of the PR starts with chart name (e.g. [velero])

@jenting jenting self-requested a review May 13, 2024 12:36
jenting
jenting previously approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contributing.

@jacksgt
Copy link
Contributor Author

jacksgt commented May 14, 2024

Hi,
I rebased the changes on latest main branch.

@qiuming-best qiuming-best merged commit f421a76 into vmware-tanzu:main May 15, 2024
13 checks passed
renovate bot referenced this pull request in teutonet/teutonet-helm-charts Jul 3, 2024
@renovate
chore(base-cluster/dependencies): update helm release velero to v6.7.0 (
84f7b52 
#954)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [velero](https://togithub.com/vmware-tanzu/velero)
([source](https://togithub.com/vmware-tanzu/helm-charts)) | minor |
`6.0.0` -> `6.7.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>vmware-tanzu/helm-charts (velero)</summary>

###
[`v6.7.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-6.7.0)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-6.6.0...velero-6.7.0)

A Helm chart for velero

#### What's Changed

- \[velero] Remove default values for resources by
[@&#8203;rissson](https://togithub.com/rissson) in
[https://github.com/vmware-tanzu/helm-charts/pull/499](https://togithub.com/vmware-tanzu/helm-charts/pull/499)

#### New Contributors

- [@&#8203;rissson](https://togithub.com/rissson) made their first
contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/499](https://togithub.com/vmware-tanzu/helm-charts/pull/499)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-6.6.0...velero-6.7.0

###
[`v6.6.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-6.6.0)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-6.5.0...velero-6.6.0)

A Helm chart for velero

#### What's Changed

- \[velero] feat(issue-584): Adds ImagePullSecrets to Velero server
ServiceAccount by
[@&#8203;Sebastian-RG](https://togithub.com/Sebastian-RG) in
[https://github.com/vmware-tanzu/helm-charts/pull/585](https://togithub.com/vmware-tanzu/helm-charts/pull/585)

#### New Contributors

- [@&#8203;Sebastian-RG](https://togithub.com/Sebastian-RG) made their
first contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/585](https://togithub.com/vmware-tanzu/helm-charts/pull/585)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-6.5.0...velero-6.6.0

###
[`v6.5.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-6.5.0)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-6.4.0...velero-6.5.0)

A Helm chart for velero

##### What's Changed

- \[velero] CI k8s 1.30 by
[@&#8203;jenting](https://togithub.com/jenting) in
[https://github.com/vmware-tanzu/helm-charts/pull/579](https://togithub.com/vmware-tanzu/helm-charts/pull/579)
- \[velero] feat(issue-582): Allow annotating
VolumeSnapshotLocation/BackupStorageLocation resources by
[@&#8203;tuusberg](https://togithub.com/tuusberg) in
[https://github.com/vmware-tanzu/helm-charts/pull/583](https://togithub.com/vmware-tanzu/helm-charts/pull/583)

##### New Contributors

- [@&#8203;tuusberg](https://togithub.com/tuusberg) made their first
contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/583](https://togithub.com/vmware-tanzu/helm-charts/pull/583)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-6.4.0...velero-6.5.0

###
[`v6.4.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-6.4.0)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-6.3.0...velero-6.4.0)

A Helm chart for velero

#### What's Changed

- \[velero] Add paused flag for the schedule resource by
[@&#8203;higashik](https://togithub.com/higashik) in
[https://github.com/vmware-tanzu/helm-charts/pull/574](https://togithub.com/vmware-tanzu/helm-charts/pull/574)

#### New Contributors

- [@&#8203;higashik](https://togithub.com/higashik) made their first
contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/574](https://togithub.com/vmware-tanzu/helm-charts/pull/574)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-6.3.0...velero-6.4.0

###
[`v6.3.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-6.3.0)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-6.2.0...velero-6.3.0)

A Helm chart for velero

#### What's Changed

- \[velero]Bump up Velero 1.13.2 by
[@&#8203;qiuming-best](https://togithub.com/qiuming-best) in
[https://github.com/vmware-tanzu/helm-charts/pull/577](https://togithub.com/vmware-tanzu/helm-charts/pull/577)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-6.2.0...velero-6.3.0

###
[`v6.2.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-6.2.0)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-6.1.0...velero-6.2.0)

A Helm chart for velero

#### What's Changed

- \[velero] Allow passing custom arguments to velero server CLI by
[@&#8203;jacksgt](https://togithub.com/jacksgt) in
[https://github.com/vmware-tanzu/helm-charts/pull/572](https://togithub.com/vmware-tanzu/helm-charts/pull/572)

#### New Contributors

- [@&#8203;jacksgt](https://togithub.com/jacksgt) made their first
contribution in
[https://github.com/vmware-tanzu/helm-charts/pull/572](https://togithub.com/vmware-tanzu/helm-charts/pull/572)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-6.1.0...velero-6.2.0

###
[`v6.1.0`](https://togithub.com/vmware-tanzu/helm-charts/releases/tag/velero-6.1.0)

[Compare
Source](https://togithub.com/vmware-tanzu/helm-charts/compare/velero-6.0.0...velero-6.1.0)

A Helm chart for velero

#### What's Changed

- \[velero] Adhere chart to semver by
[@&#8203;qiuming-best](https://togithub.com/qiuming-best) in
[https://github.com/vmware-tanzu/helm-charts/pull/569](https://togithub.com/vmware-tanzu/helm-charts/pull/569)
- Bump velero/velero from v1.13.0 to v1.13.1 in /charts/velero by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/vmware-tanzu/helm-charts/pull/557](https://togithub.com/vmware-tanzu/helm-charts/pull/557)

**Full Changelog**:
vmware-tanzu/helm-charts@velero-6.0.0...velero-6.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/teutonet/teutonet-helm-charts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting approved these changes

@qiuming-best qiuming-best qiuming-best approved these changes

@reasonerjt reasonerjt Awaiting requested review from reasonerjt

Assignees

@jacksgt jacksgt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacksgt @qiuming-best @jenting