Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init shared resources client #1006

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Init shared resources client #1006

merged 1 commit into from
Jan 16, 2025

Conversation

TaoZou1
Copy link
Contributor

@TaoZou1 TaoZou1 commented Jan 15, 2025

Init clients related to shared resources

Init clients related to shared resources
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.12%. Comparing base (6fd18c9) to head (fba0f5f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
+ Coverage   74.10%   74.12%   +0.02%     
==========================================
  Files         118      118              
  Lines       16371    16384      +13     
==========================================
+ Hits        12131    12144      +13     
  Misses       3466     3466              
  Partials      774      774              
Flag Coverage Δ
unit-tests 74.12% <100.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
pkg/nsx/client.go 84.84% <100.00%> (+1.06%) ⬆️

@TaoZou1 TaoZou1 requested a review from yanjunz97 January 15, 2025 05:44
@TaoZou1 TaoZou1 requested a review from yuntanghsu January 16, 2025 00:24
Copy link
Contributor

@yanjunz97 yanjunz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaoZou1 TaoZou1 merged commit 8b979ba into vmware-tanzu:main Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants