Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add staticroute e2e test #990

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Add staticroute e2e test #990

merged 1 commit into from
Jan 14, 2025

Conversation

TaoZou1
Copy link
Contributor

@TaoZou1 TaoZou1 commented Jan 6, 2025

Add staticroute e2e test

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.11%. Comparing base (57d792c) to head (1752630).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
+ Coverage   73.43%   74.11%   +0.68%     
==========================================
  Files         118      118              
  Lines       16362    16382      +20     
==========================================
+ Hits        12015    12142     +127     
+ Misses       3564     3466      -98     
+ Partials      783      774       -9     
Flag Coverage Δ
unit-tests 74.11% <100.00%> (+0.68%) ⬆️
Files with missing lines Coverage Δ
pkg/nsx/services/common/types.go 100.00% <ø> (ø)
pkg/nsx/services/staticroute/staticroute.go 77.27% <100.00%> (ø)

... and 8 files with indirect coverage changes

@zhengxiexie
Copy link
Contributor

/e2e

2 similar comments
@TaoZou1
Copy link
Contributor Author

TaoZou1 commented Jan 7, 2025

/e2e

@TaoZou1
Copy link
Contributor Author

TaoZou1 commented Jan 13, 2025

/e2e

@TaoZou1 TaoZou1 force-pushed the cliente2e branch 6 times, most recently from 42b051e to b6e1a1c Compare January 14, 2025 01:39
Add staticroute e2e test
Copy link
Contributor

@zhengxiexie zhengxiexie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@timdengyun timdengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaoZou1 TaoZou1 merged commit 309c616 into vmware-tanzu:main Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants