[cherry-pick] add note for backup repository password configuration #6778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
Signed-off-by: Shubham Pampattiwar <[email protected]> address PR feedback Signed-off-by: Shubham Pampattiwar <[email protected]> reword the note Signed-off-by: Shubham Pampattiwar <[email protected]> change FS backups to normal backups in the note Signed-off-by: Shubham Pampattiwar <[email protected]>
allenxu404
force-pushed
the
release-1.12
branch
from
2e9f7a6 to
6260a44
Compare
reasonerjt
approved these changes
Sep 6, 2023
kaovilai
reviewed
Sep 6, 2023
| @@ -64,6 +64,11 @@ for namespace2 would be `https://s3-us-west-2.amazonaws.com/bucket/kopia/ns2`. | |||
| There may be additional installation steps depending on the cloud provider plugin you are using. You should refer to the | |||
| [plugin specific documentation](supported-providers.md) for the must up to date information. | |||
|
|
|||
| **Note:** Currently, Velero creates a secret named `velero-repo-credentials` in the velero install namespace, containing a default backup repository password. | |||
| You can update the secret with your own password encoded as base64 prior to the first backup (i.e., FS Backup, data mover) targeting to the backup repository. The value of the key to update is `Data[repository-password]`. | |||
There was a problem hiding this comment.
This is cherry-pick but I think long term (another PR?) we would want this to be a yaml example rather than Golang map.
Suggested change
| You can update the secret with your own password encoded as base64 prior to the first backup (i.e., FS Backup, data mover) targeting to the backup repository. The value of the key to update is `Data[repository-password]`. | |
| You can update the secret with your own password encoded as base64 prior to the first backup (i.e., FS Backup, data mover) targeting to the backup repository. The value of the key to update is | |
| ``` | |
| data: | |
| repository-password: <custom-password> | |
| ``` |
There was a problem hiding this comment.
@kaovilai If we do want that, it should go into main
There was a problem hiding this comment.
This is just the release-branch PR.
sseago
approved these changes
Sep 6, 2023
kaovilai
approved these changes
Sep 6, 2023
Codecov Report
@@ Coverage Diff @@
## release-1.12 #6778 +/- ##
=============================================
Coverage 60.46% 60.46%
=============================================
Files 242 242
Lines 26005 26005
=============================================
Hits 15724 15724
Misses 9180 9180
Partials 1101 1101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.