-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix node-agent missing metrics-addr parms to define the server start. #6784 #6784
Fix node-agent missing metrics-addr parms to define the server start. #6784 #6784
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6784 +/- ##
==========================================
- Coverage 60.78% 60.78% -0.01%
==========================================
Files 250 250
Lines 26629 26632 +3
==========================================
+ Hits 16187 16188 +1
- Misses 9293 9295 +2
Partials 1149 1149
|
Taking a quick look at this PR, I think the daemonset of node agent should also expose the container port same as how Velero deployment works: |
Good catch . |
84605ae
to
74e783b
Compare
I pushd again. |
@yanggangtony Can you help repush the PR to trigger CI again since the checks didn't pass on the last run? |
Signed-off-by: yanggang <[email protected]>
74e783b
to
069c280
Compare
Yep , rebased. |
Now the codecov shows code diff issues. |
Thank you for contributing to Velero!
Please add a summary of your change
Fix node-agent missing metrics-addr parms to define the server start.
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.