Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 6748 [2] #6788

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Sep 8, 2023

Further enhance the code for #6748 -- isolate Velero snapshots by requestors, uploaders and sources so that they are not mixed from Kopia snapshot perspective. And pin Velero snapshots so that they are never deleted by Kopia retention policy

Signed-off-by: Lyndon-Li <[email protected]>
@Lyndon-Li Lyndon-Li added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Sep 8, 2023
@Lyndon-Li Lyndon-Li marked this pull request as ready for review September 8, 2023 01:52
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #6788 (9895428) into main (cddc89e) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #6788      +/-   ##
==========================================
- Coverage   60.44%   60.40%   -0.04%     
==========================================
  Files         242      242              
  Lines       26023    26027       +4     
==========================================
- Hits        15729    15722       -7     
- Misses       9190     9199       +9     
- Partials     1104     1106       +2     
Files Changed Coverage Δ
pkg/uploader/provider/kopia.go 84.07% <0.00%> (-1.64%) ⬇️
pkg/uploader/kopia/snapshot.go 81.93% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li merged commit 2348099 into vmware-tanzu:main Sep 8, 2023
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants