Add missing file licences and do some clean works. #6843
Conversation
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
| @@ -169,10 +169,10 @@ func (r *downloadRequestReconciler) Reconcile(ctx context.Context, req ctrl.Requ | |||
| Name: backup.Spec.StorageLocation, | |||
| }, location); err != nil { | |||
| if apierrors.IsNotFound(err) { | |||
| log.Errorf("BSL for DownloadRequest cannot be found") | |||
| log.Errorf("fail to get BSL for DownloadRequest") | |||
There was a problem hiding this comment.
here isn't better to have a different message from below how it was?
There was a problem hiding this comment.
mistake, thanks review.
yanggangtony
force-pushed
the
clean-and-addlicenses
branch
from
7e1d765 to
ea02aa1
Compare
|
@yanggangtony Please check the CI failure |
Oh, i messup the test code |
yanggangtony
force-pushed
the
clean-and-addlicenses
branch
from
ea02aa1 to
8c8625c
Compare
Codecov Report
@@ Coverage Diff @@
## main #6843 +/- ##
=======================================
Coverage 60.66% 60.66%
=======================================
Files 249 249
Lines 26480 26480
=======================================
Hits 16065 16065
Misses 9270 9270
Partials 1145 1145
|
| @@ -1,3 +1,18 @@ | |||
| /* | |||
| Copyright The Velero Contributors. | |||
There was a problem hiding this comment.
According to https://www.apache.org/licenses/LICENSE-2.0#apply
Year is required. Thoughts?
Copyright [yyyy] [name of copyright owner]
There was a problem hiding this comment.
I just like the license can be forever.
There was a problem hiding this comment.
Rebased , add the years.
There was a problem hiding this comment.
Actually, according to the project code standards, copyright year is to be omitted.
https://velero.io/docs/v1.12/code-standards/#copyright-header
There was a problem hiding this comment.
I'm not sure what led to the code standards decision to remove the year. It probably should be there, but the fix to that is to change the code standards (a separate issue from this).
There was a problem hiding this comment.
yes, so how to handle this case , revert to last commit? i delete the year? WDYT @sseago
There was a problem hiding this comment.
Follow the code standards guide, delete the year..🥲🥲
yanggangtony
force-pushed
the
clean-and-addlicenses
branch
from
8c8625c to
5702b8f
Compare
Signed-off-by: yanggang <[email protected]>
yanggangtony
force-pushed
the
clean-and-addlicenses
branch
from
5702b8f to
1174580
Compare
Thank you for contributing to Velero!
Please add a summary of your change
1 add missing file licences
2 fix docs error typo in
volume-snapshot-data-movement.md3 optimize the logs in
download_request_controller.goDoes your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.