-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 6861: fill repoIdentifier only for restic repo #6872
Conversation
Signed-off-by: Lyndon-Li <[email protected]>
5978561
to
10f2b79
Compare
Codecov Report
@@ Coverage Diff @@
## main #6872 +/- ##
==========================================
- Coverage 60.78% 60.77% -0.01%
==========================================
Files 245 245
Lines 26255 26264 +9
==========================================
+ Hits 15960 15963 +3
- Misses 9164 9168 +4
- Partials 1131 1133 +2
|
@sseago @shubham-pampattiwar |
Let's double check with other maintainers and adopters about the break change to remove the repo ID when restic is chosen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lyndon-Li I think only the removal of printcolumn
kubebuilder marker should be sufficient.
Signed-off-by: Lyndon-Li <[email protected]>
Signed-off-by: Lyndon-Li <[email protected]>
Fix #6861. Only Restic path requires repoIdentifier, so for non-restic path, set the repoIdentifier fields as empty in PVB and PVR and also remove the RepoIdentifier column in the get output of PVBs and PVRs