Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6861: fill repoIdentifier only for restic repo #6872

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

Lyndon-Li
Copy link
Contributor

Fix #6861. Only Restic path requires repoIdentifier, so for non-restic path, set the repoIdentifier fields as empty in PVB and PVR and also remove the RepoIdentifier column in the get output of PVBs and PVRs

@Lyndon-Li Lyndon-Li changed the title issue 6861: fill repoIdentifier only for restic repo Issue 6861: fill repoIdentifier only for restic repo Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #6872 (10f2b79) into main (d3e5bb7) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #6872      +/-   ##
==========================================
- Coverage   60.78%   60.77%   -0.01%     
==========================================
  Files         245      245              
  Lines       26255    26264       +9     
==========================================
+ Hits        15960    15963       +3     
- Misses       9164     9168       +4     
- Partials     1131     1133       +2     
Files Coverage Δ
pkg/podvolume/backupper.go 85.94% <40.00%> (-1.00%) ⬇️
pkg/podvolume/restorer.go 90.00% <40.00%> (-1.40%) ⬇️

... and 1 file with indirect coverage changes

@Lyndon-Li
Copy link
Contributor Author

@sseago @shubham-pampattiwar
Please help to review this PR. We want to remove the Repository ID column from the output of kubectl get podvolumebackup, since kopia is not the default path and it is always empty for kopia path.

@reasonerjt
Copy link
Contributor

Let's double check with other maintainers and adopters about the break change to remove the repo ID when restic is chosen.

Copy link
Collaborator

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lyndon-Li I think only the removal of printcolumn kubebuilder marker should be sufficient.

@sseago sseago merged commit 73ea00b into vmware-tanzu:main Sep 27, 2023
25 of 27 checks passed
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Oct 2, 2023
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podvolumebackups still reference Restic in repository ID path (repoIdentifier) after switching to Kopia
4 participants