Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6859: move plugin depdending podvolume functions to util pkg #6875

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Sep 26, 2023

Fix #6859, move plugin depending podvolume functions to util pkg, so as to remove the dependencies to unnecessary repository packages like kopia, azure, etc.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #6875 (2e71cff) into main (c3ec7b7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6875   +/-   ##
=======================================
  Coverage   60.78%   60.78%           
=======================================
  Files         245      246    +1     
  Lines       26256    26256           
=======================================
  Hits        15961    15961           
  Misses       9164     9164           
  Partials     1131     1131           
Files Coverage Δ
pkg/backup/item_backupper.go 69.70% <100.00%> (ø)
pkg/podvolume/util.go 81.60% <ø> (-6.80%) ⬇️
pkg/util/podvolume/pod_volume.go 100.00% <100.00%> (ø)

@kaovilai
Copy link
Member

kaovilai commented Sep 27, 2023

If PR description has

Fix #6859

rather than

Fix issue #6859

it would link and close the issue when this merges.

Issue would show up here
image

@Lyndon-Li Lyndon-Li marked this pull request as ready for review September 27, 2023 01:12
@Lyndon-Li Lyndon-Li merged commit b6b320c into vmware-tanzu:main Sep 27, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Velero plugins depends on Velero's Repository package unnecessarily
5 participants