Create the backup repository only when it doesn't exist #6884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywk253100
added
the
kind/changelog-not-required
Lyndon-Li
previously approved these changes
Sep 28, 2023
qiuming-best
previously approved these changes
Sep 28, 2023
When preparing a backup repository, Velero tries to connect to it, if fails then create it. The repository status always records the error reported by creation but the real reason maybe caused by the connect operation. This is confuseing and hard to debug Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100
dismissed stale reviews from qiuming-best and Lyndon-Li
via
61a6c1b
ywk253100
force-pushed
the
230928_repo_init
branch
from
2faa51b to
61a6c1b
Compare
Codecov Report
@@ Coverage Diff @@
## main #6884 +/- ##
==========================================
+ Coverage 60.75% 60.76% +0.01%
==========================================
Files 247 247
Lines 26314 26322 +8
==========================================
+ Hits 15987 15995 +8
Misses 9190 9190
Partials 1137 1137
|
Lyndon-Li
approved these changes
Sep 28, 2023
qiuming-best
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preparing a backup repository, Velero tries to connect to it, if fails then create it. The repository status always records the error reported by creation but the real reason maybe caused by the connect operation. This is confuseing and hard to debug
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.