Update restore logic to allow Resource Modifiers to use data from the status field #8121
Conversation
… status field Signed-off-by: Baudouin Herlicq <[email protected]>
Signed-off-by: Baudouin Herlicq <[email protected]>
BaudouinH
force-pushed
the
allow-usage-of-status-field-in-resource-modifiers
branch
from
b8e9fb0 to
e90ddd4
Compare
Signed-off-by: Baudouin Herlicq <[email protected]>
Signed-off-by: Baudouin Herlicq <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8121 +/- ##
==========================================
- Coverage 59.03% 59.02% -0.02%
==========================================
Files 358 364 +6
Lines 30141 30272 +131
==========================================
+ Hits 17795 17868 +73
- Misses 10907 10958 +51
- Partials 1439 1446 +7 ☔ View full report in Codecov by Sentry. |
| @@ -58,6 +58,11 @@ resourceModifierRules: | |||
| - copy | |||
| - test (covered below) | |||
|
|
|||
| ### Limitations of Resource Modifiers | |||
There was a problem hiding this comment.
Can you please move limitations section to the bottom of the docs?
There was a problem hiding this comment.
@BaudouinH, pl check this
| } | ||
|
|
||
| ctx.log.Infof("restore status includes excludes: %+v", ctx.resourceStatusIncludesExcludes) | ||
|
|
There was a problem hiding this comment.
the concern that @reasonerjt had in #8094 (comment) still holds.
Please pitch in others - CC: @sseago, if this could impact any RIA flows.
There was a problem hiding this comment.
Otherwise please signoff - @reasonerjt
There was a problem hiding this comment.
@anshulahuja98 I'm unaware of any RIA that currently modifies status -- if I'm remembering correctly, don't we currently strip the status field before RIAs are run? I think that's one of the reasons we added unmodified item (itemFromBackup) to the RIA input, as it still has the full status available for plugins to reference.
Thank you for contributing to Velero!
Please add a summary of your change
This PR change slightly the restore logic to make it possible to use the
statusfield in Restore Resource Modifiers.The status field is now trimmed after applying the resource modifiers, not before, allowing patches in resource modifiers to reference the
statusfield.Does your change fix a particular issue?
Fixes #8094
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.