-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multi-arch manifest-list from make container
#8252
Merged
shubham-pampattiwar
merged 2 commits into
vmware-tanzu:main
from
kaovilai:mkcontainer-multiplat
Nov 14, 2024
Merged
Allow multi-arch manifest-list from make container
#8252
shubham-pampattiwar
merged 2 commits into
vmware-tanzu:main
from
kaovilai:mkcontainer-multiplat
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
PR does not require a user changelog. Often for docs, website, or build changes
label
Sep 27, 2024
by changing output type to image. Then you can execute command like so to create a multi-arch image ``` BUILDX_PLATFORMS=linux/amd64,linux/arm64 BUILDX_OUTPUT_TYPE=image make container ``` Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
mkcontainer-multiplat
branch
from
September 27, 2024 14:29
782275d
to
a441687
Compare
mateusoliveira43
approved these changes
Sep 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8252 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 367 367
Lines 30841 30841
=======================================
Hits 18262 18262
Misses 11119 11119
Partials 1460 1460 ☔ View full report in Codecov by Sentry. |
blackpiglet
reviewed
Sep 29, 2024
Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
mkcontainer-multiplat
branch
from
October 1, 2024 20:16
d97885b
to
3f4a1c2
Compare
shubham-pampattiwar
approved these changes
Nov 1, 2024
blackpiglet
approved these changes
Nov 4, 2024
sseago
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/changelog-not-required
PR does not require a user changelog. Often for docs, website, or build changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by changing output type to image.
Then you can execute command like so to create a multi-arch image
When output type is docker, only single arch is supported and following error is observed.
Signed-off-by: Tiger Kaovilai [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.