Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multi-arch manifest-list from make container #8252

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Sep 27, 2024

by changing output type to image.

Then you can execute command like so to create a multi-arch image

BUILDX_PLATFORMS=linux/amd64,linux/arm64 make container

When output type is docker, only single arch is supported and following error is observed.

ERROR: docker exporter does not currently support exporting manifest lists

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@kaovilai
Copy link
Member Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Sep 27, 2024
by changing output type to image.

Then you can execute command like so to create a multi-arch image
```
BUILDX_PLATFORMS=linux/amd64,linux/arm64 BUILDX_OUTPUT_TYPE=image make container
```

Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai force-pushed the mkcontainer-multiplat branch from 782275d to a441687 Compare September 27, 2024 14:29
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.21%. Comparing base (aab2140) to head (3f4a1c2).
Report is 76 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8252   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files         367      367           
  Lines       30841    30841           
=======================================
  Hits        18262    18262           
  Misses      11119    11119           
  Partials     1460     1460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai force-pushed the mkcontainer-multiplat branch from d97885b to 3f4a1c2 Compare October 1, 2024 20:16
@shubham-pampattiwar shubham-pampattiwar merged commit 7a51e0d into vmware-tanzu:main Nov 14, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants