fix(pkg/repository/maintenance): handle when there's no container status

[mcluseau]

Fixes a crash in this case.

panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

goroutine 562 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:116 +0x1e5
panic({0x2ae2cc0?, 0xc001a084b0?})
	/usr/local/go/src/runtime/panic.go:770 +0x132
github.com/vmware-tanzu/velero/pkg/repository.GetMaintenanceResultFromJob({0x318cd00, 0xc0009be3f0}, 0xc0025ae508)
	/go/src/github.com/vmware-tanzu/velero/pkg/repository/maintenance.go:120 +0x229

[mcluseau]

Hi @mateusoliveira43 , sure, I've updated the comments and the error

[mcluseau]

if you're like me, you'd notice rust would have made the problem much more obvious in the first place 😅

[mateusoliveira43]

@mcluseau yeah, Go errors are almost unreadable, thanks for taking time to fix this!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (c53ab20) to head (e770f0c).
Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8271      +/-   ##
==========================================
+ Coverage   58.99%   59.00%   +0.01%     
==========================================
  Files         367      367              
  Lines       38847    38857      +10     
==========================================
+ Hits        22918    22928      +10     
  Misses      14467    14467              
  Partials     1462     1462              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kaovilai]

@mcluseau please add changelog

[kaovilai]

Add changelog here
https://github.com/vmware-tanzu/velero/tree/main/changelogs/unreleased
File name: <pr-num>-<gh-username>

[kaovilai]

IMO. but not blocked on it.

[Lyndon-Li]

@mcluseau
Please don't resolve the comments until consensus are made with the commenter, otherwise, maintainers may think the PR is ready and merge it.

[mcluseau]

@mcluseau Please don't resolve the comments until consensus are made with the commenter, otherwise, maintainers may think the PR is ready and merge it.

2 weeks looked like a lazy consensus to me, but ok, I won't touch those buttons again 😅

[Lyndon-Li]

We are creating release of 1.15, let's merge this PR after 1.15 branch is cut.