-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the context choosing error after migration case. #8293
Fix the context choosing error after migration case. #8293
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8293 +/- ##
==========================================
- Coverage 59.20% 59.19% -0.02%
==========================================
Files 367 367
Lines 30838 30840 +2
==========================================
- Hits 18259 18255 -4
- Misses 11119 11124 +5
- Partials 1460 1461 +1 ☔ View full report in Codecov by Sentry. |
75452a1
to
587634f
Compare
@@ -53,7 +53,7 @@ GINKGO_LABELS ?= | |||
# When --fail-fast is set, the entire suite will stop when the first failure occurs. | |||
# Enable --fail-fast by default. | |||
# https://onsi.github.io/ginkgo/#mental-model-how-ginkgo-handles-failure | |||
FAIL_FAST ?= true | |||
FAIL_FAST ?= false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the impact for this change? will it take more time for testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FAIL_FAST
flag determines how to handle errors met during the test suite running.
If FAIL_FAST
is set to true
, the test suite stops running immediately.
If FAIL_FAST
is set to false
, the test suite continues running on meeting test error.
The FAIL_FAST
flag is introduced to help debug the test error, so set the default value to false, and let the Jenkins pipeline can pass the value to determine whether the flag should be turned on.
587634f
to
d644116
Compare
Change the FAIL_FAST default value to false. Signed-off-by: Xun Jiang <[email protected]>
d644116
to
6a1d8df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Try to use the normal import way in ginkgo tests.
Change the FAIL_FAST default value to false.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.