Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hinting region to use for GetBucketRegion() in pkg/repository/config/aws.go #8297

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Oct 14, 2024

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #8296
Similar to vmware-tanzu/velero-plugin-for-aws#210

To test this PR, you would create aws BSL without region and attempt to backup using kopia/data mover

Please indicate you've done the following:

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 59.20%. Comparing base (b34e011) to head (69b456a).
Report is 135 commits behind head on main.

Files with missing lines Patch % Lines
pkg/repository/config/aws.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8297      +/-   ##
==========================================
+ Coverage   59.18%   59.20%   +0.01%     
==========================================
  Files         367      367              
  Lines       30838    30846       +8     
==========================================
+ Hits        18253    18261       +8     
- Misses      11124    11125       +1     
+ Partials     1461     1460       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubham-pampattiwar
Copy link
Collaborator

cc: @reasonerjt

@reasonerjt
Copy link
Contributor

@shubham-pampattiwar @sseago @kaovilai

LGTM, but shall we hold it after the branch is cut for v1.15? Unfortunately we see issues in the internal pipeline and still fixing it.

@sseago
Copy link
Collaborator

sseago commented Oct 21, 2024

@reasonerjt since this isn't a 1.15 regression (the bug is there in 1.14 as well), I don't think it's a 1.15 blocker. I'm fine with holding off until the branch is cut, and then we can target for 1.15.1.
@kaovilai Does that work for you?

@kaovilai
Copy link
Member Author

Sure

@reasonerjt reasonerjt merged commit eb48cbd into vmware-tanzu:main Dec 11, 2024
88 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/repository/config/aws.go: GetAWSBucketRegion: missing region hint
4 participants