Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a warning during make container #8338

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Oct 23, 2024

Fix a warning during make container:

 1 warning found (use docker --debug to expand):                                                                                                             
 - UndefinedVar: Usage of undefined variable '$GOPROXY' (line 58)

@Lyndon-Li Lyndon-Li marked this pull request as ready for review October 23, 2024 07:40
@Lyndon-Li Lyndon-Li added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Oct 23, 2024
@Lyndon-Li Lyndon-Li requested a review from ywk253100 October 23, 2024 07:41
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.99%. Comparing base (a9b5dbc) to head (fa7fca8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8338   +/-   ##
=======================================
  Coverage   58.99%   58.99%           
=======================================
  Files         367      367           
  Lines       38847    38847           
=======================================
  Hits        22918    22918           
  Misses      14467    14467           
  Partials     1462     1462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li merged commit ebbeb7a into vmware-tanzu:main Oct 23, 2024
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants