Copy "envFrom" from Velero server when creating maintenance jobs

[evhan]

Thank you for contributing to Velero!

Please add a summary of your change

When the Velero server creates a maintenance job, it copies its own env into the newly-created Pod spec. However, Velero's environment may be populated via envFrom in addition to env, in which case the maintenance job may fail since it will be missing potentially-important variables.

We ran into this while using the OpenStack plugin, but the issue is not specific to that provider. We worked around the problem in the meantime by moving all variables that were previously stored in a Secret into the Deployment itself.

The documentation already says:

Maintenance jobs will inherit the labels, annotations, toleration, nodeSelector, service account, image, environment variables, cloud-credentials etc. from Velero deployment.

This would appear to be covered by that, and the change is just bringing the implementation in line with the docs.

Does your change fix a particular issue?

No existing issue in GitHub from what I can see.

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file (make new-changelog) or comment /kind changelog-not-required on this PR.
• Updated the corresponding documentation in site/content/docs/main.

[codecov]

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.98%. Comparing base (ebbeb7a) to head (f981dd4).
Report is 46 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/util/velero/velero.go	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8343      +/-   ##
==========================================
- Coverage   58.99%   58.98%   -0.01%     
==========================================
  Files         367      367              
  Lines       38847    38889      +42     
==========================================
+ Hits        22918    22940      +22     
- Misses      14467    14487      +20     
  Partials     1462     1462              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Lyndon-Li]

This looks like a valid issue for both maintenance job and data mover pods, but by default Velero doesn't set envFrom, so we will not include it in 1.15 RC.2.

[Lyndon-Li]

@evhan
Could you also help to fix the same problem for data mover pods? The code should be around functions createBackupPod and createRestorePod.

[reasonerjt]

@evhan Thanks for the PR. We appreciate your contribution.

But could you also add a UT?

[evhan]

@evhan Thanks for the PR. We appreciate your contribution.

But could you also add a UT?

Sure. I'll also look at fixing the issue for the data mover pods. Would you like that in the same PR or a new one?

[Lyndon-Li]

Would you like that in the same PR or a new one?

All been included in the current PR will be fine. Thanks.

[evhan]

All been included in the current PR will be fine. Thanks.

No problem. I've added the same treatment for the data mover pods and added env/envFrom to the tests to make sure they're included. Hope that looks OK.

[shubham-pampattiwar]

Thank you @evhan for the contribution. CI is failing on make update. Can please you execute make update and update the pull request ?

[evhan]

Thank you @evhan for the contribution. CI is failing on make update. Can please you execute make update and update the pull request ?

Yeah, just noticed, sorry about that. Should be fixed now!

[kaovilai]

This LGTM. Thank you!