Use aggregated discovery API to discovery API groups and resources #8353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use aggregated discovery API to discovery API groups and resources Fixes vmware-tanzu#7526 Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100
force-pushed
the
241010_discovery
branch
from
7738f5a to
0784792
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8353 +/- ##
==========================================
- Coverage 58.97% 58.95% -0.03%
==========================================
Files 367 367
Lines 38876 38890 +14
==========================================
Hits 22928 22928
- Misses 14486 14500 +14
Partials 1462 1462 ☔ View full report in Codecov by Sentry. |
kaovilai
reviewed
Oct 28, 2024
kaovilai
approved these changes
Oct 30, 2024
blackpiglet
reviewed
Oct 31, 2024
|
@blackpiglet @shubham-pampattiwar @Lyndon-Li Could you take a look at this PR again? |
shubham-pampattiwar
approved these changes
Nov 5, 2024
|
@ywk253100 Are we planning to conduct any performance testing to measure how much the backup operation’s performance improves with the PR changes? |
blackpiglet
approved these changes
Nov 5, 2024
Lyndon-Li
approved these changes
Nov 5, 2024
No plan at this moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use aggregated discovery API to discovery API groups and resources
Fixes #7526
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.